Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edgebadge: embedded-graphics 0.8.0+ compatibility #724

Closed
LuckyTurtleDev opened this issue Feb 8, 2024 · 3 comments · Fixed by #726
Closed

edgebadge: embedded-graphics 0.8.0+ compatibility #724

LuckyTurtleDev opened this issue Feb 8, 2024 · 3 comments · Fixed by #726

Comments

@LuckyTurtleDev
Copy link
Contributor

LuckyTurtleDev commented Feb 8, 2024

The edgebade does still stuck on embeded-graphics 0.7.0 because of the outdated st7735-lcd-rs crate.

see also: LuckyTurtleDev/pybadge-high#11

@LuckyTurtleDev
Copy link
Contributor Author

I currently do not have access to an edgebade for testing. Wwould it be ok to simple increase the st7735-lcd-rs crate version and keep everything else the same?

@jbeaurivage
Copy link
Contributor

Hey @LuckyTurtleDev, as I understand it, you want to bump the embedded-graphics dependency of edgebadge, correct?
You can open a PR with the appropriate version bumps, and we will review it.

@LuckyTurtleDev
Copy link
Contributor Author

Hey @LuckyTurtleDev, as I understand it, you want to bump the embedded-graphics dependency of edgebadge, correct? You can open a PR with the appropriate version bumps, and we will review it.

Yes, I planed it for today. But it looks like @orsinium was faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants