Merge upstream feature/distributed-demo into main

Author: atomicgamedeveloper

.github/agents/expert-react-frontend-engineer.agent.md

@@ -2,16 +2,16 @@
 description: "Expert React 19.2 frontend engineer specializing in modern hooks, Server Components, Actions, TypeScript, and performance optimization"
 name: "Expert React Frontend Engineer"
 tools: ["search/changes", "search/codebase", "edit/editFiles",
-"vscode/extensions", "web/fetch", "web/githubRepo",
-"vscode/getProjectSetupInfo", "vscode/installExtension",
-"vscode/newWorkspace", "vscode/runCommand", "read/problems",
-"execute/getTerminalOutput", "execute/runInTerminal",
-"read/terminalLastCommand", "read/terminalSelection",
-"execute/createAndRunTask", "execute/getTaskOutput",
-"execute/runTask", "execute/runTests", "search",
-"search/searchResults", "read/terminalLastCommand",
-"read/terminalSelection", "execute/testFailure", "search/usages",
-"vscode/vscodeAPI"]
+  "vscode/extensions", "web/fetch", "web/githubRepo",
+  "vscode/getProjectSetupInfo", "vscode/installExtension",
+  "vscode/newWorkspace", "vscode/runCommand", "read/problems",
+  "execute/getTerminalOutput", "execute/runInTerminal",
+  "read/terminalLastCommand", "read/terminalSelection",
+  "execute/createAndRunTask", "execute/getTaskOutput",
+  "execute/runTask", "execute/runTests", "search",
+  "search/searchResults", "read/terminalLastCommand",
+  "read/terminalSelection", "execute/testFailure", "search/usages",
+  "vscode/vscodeAPI"]
 ---
 
 # Expert React Frontend Engineer

.gitignore

@@ -196,11 +196,9 @@ deploy/services/gitlab/config/
 
 # config files
 services.env
-credentials.csv
 deploy/services/certs/*
 !deploy/services/certs/services.foo.com
 deploy/services/cli/certs/*
-deploy/services/cli/config/
 deploy/services/cli/data
 
 # qlty config
@@ -212,21 +210,36 @@ deploy/services/cli/data
 *.coverage
 coverage.xml
 
+
+deploy/services/cli/revenv/
+
 # Copied build artifacts (generated by build.py)
 deploy/services/cli/dtaas_services/config/
 deploy/services/cli/dtaas_services/data/
+deploy/services/cli/dtaas_services/certs/
+deploy/services/cli/dtaas_services/log/
 deploy/services/cli/dtaas_services/compose.services.secure.yml
 deploy/services/cli/dtaas_services/compose.thingsboard.secure.yml
 #ignore developer files
 docker/.env
 docker/conf.dev
-deploy/services/data
-deploy/services/config
-deploy/services/cli/compose.services.secure.yml
 
-deploy/services/cli/data
+# Deploy services data
+deploy/services/data/*
+!deploy/services/data/.gitkeep
+deploy/services/data/*/*
+!deploy/services/data/*/.gitkeep
+deploy/services/cli/config/influxdb
+
+deploy/services/cli/log/thingsboard
+
+deploy/services/config/credentials.csv
+deploy/services/cli/config/credentials.csv
 deploy/services/cli/config
+deploy/services/cli/compose.services.secure.yml
+deploy/services/cli/compose.thingsboard.secure.yml
+
 deploy/services/cli/test-output
 
 # local research papers
-.research-papers
+.research-papers

CLAUDE.md

@@ -0,0 +1,76 @@
+# CLAUDE.md
+
+Behavioral guidelines to reduce common LLM coding mistakes. Merge with
+project-specific instructions as needed.
+
+**Tradeoff:** These guidelines bias toward caution over speed.
+For trivial tasks, use judgment.
+
+## 1. Think Before Coding
+
+**Don't assume. Don't hide confusion. Surface tradeoffs.**
+
+Before implementing:
+
+- State your assumptions explicitly. If uncertain, ask.
+- If multiple interpretations exist, present them — don't pick silently.
+- If a simpler approach exists, say so. Push back when warranted.
+- If something is unclear, stop. Name what's confusing. Ask.
+
+## 2. Simplicity First
+
+**Minimum code that solves the problem. Nothing speculative.**
+
+- No features beyond what was asked.
+- No abstractions for single-use code.
+- No "flexibility" or "configurability" that wasn't requested.
+- No error handling for impossible scenarios.
+- If you write 200 lines and it could be 50, rewrite it.
+
+Ask yourself: "Would a senior engineer say this is overcomplicated?"
+If yes, simplify.
+
+## 3. Surgical Changes
+
+**Touch only what you must. Clean up only your own mess.**
+
+When editing existing code:
+
+- Don't "improve" adjacent code, comments, or formatting.
+- Don't refactor things that aren't broken.
+- Match existing style, even if you'd do it differently.
+- If you notice unrelated dead code, mention it — don't delete it.
+
+When your changes create orphans:
+
+- Remove imports/variables/functions that YOUR changes made unused.
+- Don't remove pre-existing dead code unless asked.
+
+The test: Every changed line should trace directly to the user's request.
+
+## 4. Goal-Driven Execution
+
+**Define success criteria. Loop until verified.**
+
+Transform tasks into verifiable goals:
+
+- "Add validation" → "Write tests for invalid inputs, then make them pass"
+- "Fix the bug" → "Write a test that reproduces it, then make it pass"
+- "Refactor X" → "Ensure tests pass before and after"
+
+For multi-step tasks, state a brief plan:
+
+```text
+1. [Step] → verify: [check]
+2. [Step] → verify: [check]
+3. [Step] → verify: [check]
+```
+
+Strong success criteria let you loop independently.
+Weak criteria ("make it work") require constant clarification.
+
+---
+
+**These guidelines are working if:** fewer unnecessary changes in diffs,
+fewer rewrites due to overcomplication, and clarifying questions
+come before implementation rather than after mistakes.

client/README.md

@@ -105,24 +105,24 @@ one project runner in your GitLab profile. Follow the steps below:
 
 1. Login to the GitLab profile that will be used as the OAuth provider.
 
-1. Navigate to the *DTaaS* group and select the project named after your
+1. Navigate to the _DTaaS_ group and select the project named after your
    GitLab username.
 
 1. In the project menu, go to Settings and select CI/CD.
 
-1. Expand the **Runners** section and click on *New project runner*. Follow the
+1. Expand the **Runners** section and click on _New project runner_. Follow the
    configuration instructions carefully:
    - Add **linux** as a tag during configuration.
-   - Click on *Create runner*.
+   - Click on _Create runner_.
    - Ensure GitLab Runner is installed before proceeding. Depending on your
      environment, you will be shown the correct command to install GitLab Runner.
    - Once GitLab Runner is installed, follow these steps to register the runner:
      - Copy and paste the command shown in the GitLab interface into your command
        line to register the runner. It includes a URL and a token for your specific
        GitLab instance.
-     - Choose *docker* as executor when prompted by the command line.
+     - Choose _docker_ as executor when prompted by the command line.
      - Choose the default docker image. You must use an image based on Linux,
-       like the default one (*ruby:2.7*).
+       like the default one (_ruby:2.7_).
 
 You can manually verify that the runner is available to pick up jobs by running
 the following command:
@@ -136,8 +136,8 @@ It can also be used to reactivate offline runners during subsequent sessions.
 ## Digital Twins page preview
 
 In the Workbench section, there is a link to preview the **Digital Twins**
-page. The GitLab account used as OAuth provider must have a *DTaaS* group,
-a project under your username, and a *digital_twins* folder which contains
+page. The GitLab account used as OAuth provider must have a _DTaaS_ group,
+a project under your username, and a _digital_twins_ folder which contains
 the Digital Twins.
 
 In the Manage tab, you can read the README.md file of the selected Digital

client/compose.client.yml

@@ -5,4 +5,4 @@ services:
     volumes:
       - ./config/test.js:/dtaas/client/build/env.js
     ports:
-      - "4000:4000"
+      - '4000:4000'

client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@into-cps-association/dtaas-web",
-  "version": "0.10.2",
+  "version": "0.10.3",
   "description": "Web client for Digital Twin as a Service (DTaaS)",
   "main": "index.tsx",
   "author": "prasadtalasila <prasad.talasila@gmail.com> (http://prasad.talasila.in/)",

client/public/index.html

@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
   <head>
     <meta charset="utf-8" />

client/src/components/LinkButtons.tsx

@@ -26,7 +26,7 @@ interface IconButtonData {
 }
 const getIconButtons = (buttons: KeyLinkPair[]): IconButtonData[] =>
   buttons.map((button) => {
-    const iconData = LinkIcons[button.key.toUpperCase()];
+    const iconData = LinkIcons[button.key.toUpperCase()] ?? LinkIcons.NO_ICON;
 
     return {
       link: button.link,

…iew/components/asset/AddToCartButton.tsx …src/components/asset/AddToCartButton.tsxclient/src/preview/components/asset/AddToCartButton.tsx renamed to client/src/components/asset/AddToCartButton.tsx client/src/preview/components/asset/AddToCartButton.tsx renamed to client/src/components/asset/AddToCartButton.tsx

@@ -1,45 +1,46 @@
 import { Button } from '@mui/material';
 import LibraryAsset from 'model/backend/libraryAsset';
-import useCart from 'preview/store/CartAccess';
+import useCart from 'model/store/CartAccess';
 import { useSelector } from 'react-redux';
-import { selectAssetByPathAndPrivacy } from 'preview/store/assets.slice';
+import { selectAssetByPathAndPrivacy } from 'model/store/assets.slice';
 
 interface AddToCartButtonProps {
-  assetPath: string;
-  assetPrivacy: boolean;
+  readonly assetPath: string;
+  readonly assetPrivacy: boolean;
 }
 
+// Helper to check if asset is in cart
+const isAssetInCart = (
+  cartAssets: LibraryAsset[],
+  asset: LibraryAsset,
+): boolean =>
+  cartAssets.some(
+    (item: LibraryAsset) =>
+      item.path === asset.path && item.isPrivate === asset.isPrivate,
+  );
+
 function AddToCartButton({ assetPath, assetPrivacy }: AddToCartButtonProps) {
   const { state: cartState, actions } = useCart();
   const asset = useSelector(
     selectAssetByPathAndPrivacy(assetPath, assetPrivacy),
   ) as LibraryAsset;
 
-  const isInCart = cartState.assets.some(
-    (item: LibraryAsset) =>
-      item.path === asset.path && item.isPrivate === asset.isPrivate,
-  );
-
-  const handleAddToCart = async () => {
-    actions.add(asset);
-  };
+  const isInCart = isAssetInCart(cartState.assets, asset);
 
-  const handleRemoveFromCart = async () => {
-    actions.remove(asset);
+  const handleClick = () => {
+    if (isInCart) {
+      actions.remove(asset);
+    } else {
+      actions.add(asset);
+    }
   };
 
   return (
     <Button
       variant="contained"
       size="small"
       color="primary"
-      onClick={() => {
-        if (isInCart) {
-          handleRemoveFromCart();
-        } else {
-          handleAddToCart();
-        }
-      }}
+      onClick={handleClick}
     >
       {isInCart ? 'Remove' : 'Add'}
     </Button>