inline `const` declarations regex bug

const a = 1
const b = 2

is consistent but

const a = 1, b = 2, c = 3

does not properly color code b or anything after.

[Victorystick]

I know. I tried to tackle this a while back, but it's very difficult to define a matching rule for the later constants. If anyone has any ideas I'm all ears.

For example:

// Can't look for commas and identifiers (, b)
// since we might see a function or array literal.
const a = function (a, b) { return a * b; }, b = 5;
const c = [ a, b ], d = e;

At the time I settled on a match for the first identifier only (including destructuring).

const [ a, b, ...x ] = arr1, [ c, d, ...y ] = arr2;

[Victorystick]

Funny how y got highlighted.

Funny how y got highlighted.

😆

[jamen]

Hey recently ran into this issue, what's the progress?

[jamen]

Not even sure this is possible with Regex matching, considering the other ES6 features...

Take default function parameters for instance...

const foo = function(bar = 1, baz = 2){}, qux = 1;

Any clue on how you'd approach that?

[winstliu]

I think the key here is to look for commas and add subpatterns for the function, etc stuff so that they don't get matched.

[winstliu]

From #470:

const {a, b = 0, c = 1} = obj
const [d, e = 2, f = 3] = arr
const {foo: [g, h = 4, i = 5], bar: [j, k, l]} = objarr
const [{m, n = 6, o = 7}, {p, q, r}] = arrobj
const {foo: s, bar: t = 8, baz: u = 9} = rn