Fix/update trainee info #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mugishaj092
requested changes
Sep 20, 2024
will that be user friendly? I thought we should keep it open, because like especially if there's a chance the user might want to make further changes or if they need to correct a mistake right away. what do you think? @mugishaj092 |
Prince-Kid
approved these changes
Sep 20, 2024
mugishaj092
approved these changes
Sep 23, 2024
tysepa
approved these changes
Sep 23, 2024
mugishaj092
added
In progress
and removed
Ready For Review
MnorbertVii
force-pushed
the
fix/update-trainee-info
branch
2 times, most recently
from
460a58a
to
ed854d3
Compare
MnorbertVii
added
Ready For Review
robsdagreat
approved these changes
Sep 25, 2024
MnorbertVii
force-pushed
the
fix/update-trainee-info
branch
from
0eace5f
to
d167c5a
Compare
|
Code Climate has analyzed commit d167c5a and detected 0 issues on this pull request. View more on Code Climate. |
Ishimwe7
pushed a commit
that referenced
this pull request
Oct 10, 2024
* add validations and work on edit * ensure birthdate is correctly set in formData * ensure all formData are populated correctly * fix codeclimate issue * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * fix traineUpdate * add loader * add sidebar link for trainee applicants * add redirection after updating
Ismaelmurekezi
pushed a commit
that referenced
this pull request
Oct 13, 2024
* add validations and work on edit * ensure birthdate is correctly set in formData * ensure all formData are populated correctly * fix codeclimate issue * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * fix traineUpdate * add loader * add sidebar link for trainee applicants * add redirection after updating
Philimuhire
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Add Not Found Page * Add Sign In Profile Picture Ft-send-bulky-email (#61) * new * added a send email model * email * email Co-authored-by: UmuhireJessie <[email protected]> TO be removed fix: run the app ft-superadmin-roles&permissions(superadmin can view members) feat(ft-user-register): user should be able to create account superAdmin register user fix(routes): Add routes directory add login page and add name field on user registration by superadmin create program bg: Added Loader ft(): programs page role & permission implementation of delete role and permissions ft():delete program implementation of delete role and permissions feature:Application form using Google Form implementation of delete role and permissions ft(): edit program new changes ft():Applicant Dashboard add grading system form feat(admin list applications):view applications ft admin view applications admin update status of candidate application Feature github actions (#119) * fix: remove placeholder property * Have github actions setup with necessary jobs * Have code climate errors removed * Corrected codeclimate issues * --ammend * --ammend --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Ndahimana Bonheur <[email protected]> * fix: remove placeholder property * #103 Navigation fixed --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Ndahimana Bonheur <[email protected]> Fix number can't be shared (#130) Co-authored-by: Mugisha <[email protected]> * fix: remove placeholder property * fix duplicate links --------- Co-authored-by: ceelogre <[email protected]> Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- Co-authored-by: ceelogre <[email protected]> Ft shareable job post (#139) * fix: remove placeholder property * Ft():shareable job post page * Feature: Adding shareable job post buttons * Feature: Adding shareable job post buttons * Feature: Adding shareable job post buttons * fix codeclimate issue * add gmail and fix telegram link * add gmail sharing * fix url sharing * fix url * fix url * fix codeclimate * applicant share application --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: dean-daryl <[email protected]> Co-authored-by: Bahati <[email protected]> Co-authored-by: uwituzeb <[email protected]> Ft add favicon (#124) * fix: remove placeholder property * add favicon svg * added favicon * removed unneccessary added port number * resolved conflicts * resolved conflicts * resolved conflicts * add favicon svg * resolved conflicts * removed unneccessary added port number * resolved conflicts * resolved conflicts * added favicon * removed unneccessary added port number * resolved conflicts * resolved conflicts * resolved conflicts * added favicon * removed unneccessary added port number * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts --------- Co-authored-by: ceelogre <[email protected]> Fix tel (#123) * fix: remove placeholder property * fix code & tell issue * rebasing * fix code issue --------- Co-authored-by: ceelogre <[email protected]> Fix/update trainee info (#137) * add validations and work on edit * ensure birthdate is correctly set in formData * ensure all formData are populated correctly * fix codeclimate issue * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * fix traineUpdate * add loader * add sidebar link for trainee applicants * add redirection after updating * feature: improve trainee details page * handling missing application info, also adding download functionality * fixing error related to download and refactoring * Update TrainneeDetails.tsx * handling issues related to deployment * Fix number can't be shared (#130) Co-authored-by: Mugisha <[email protected]> * #102 sidebar links review (#128) * fix: remove placeholder property * fix duplicate links --------- Co-authored-by: ceelogre <[email protected]> * Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> * #118 fx: builtinSuperAdminCreateProgram (#126) * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- Co-authored-by: ceelogre <[email protected]> * feature: improve trainee details page * handling missing application info, also adding download functionality * Update TrainneeDetails.tsx * adding way to send email and other adjustments * refining and fixing some issues * Update webpack.config.js * customizing way of sending email * refactoring code to fix issue related to code climate * fixing issue for deployment * fixing issues related to refactoring --------- Co-authored-by: MUGISHA Emmanuel <[email protected]> Co-authored-by: Mugisha <[email protected]> Co-authored-by: ISHIMWE Jean Baptiste <[email protected]> Co-authored-by: ceelogre <[email protected]> Co-authored-by: ManziPatrick <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> Co-authored-by: Niyonshuti Jean De Dieu <[email protected]> fixes #168 auth and admin login (#169) * feature: improve trainee details page (#172) * handling missing application info, also adding download functionality * fixing error related to download and refactoring * Update TrainneeDetails.tsx * handling issues related to deployment * Fix number can't be shared (#130) * #102 sidebar links review (#128) * fix: remove placeholder property * fix duplicate links --------- * Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- * #118 fx: builtinSuperAdminCreateProgram (#126) * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- * feature: improve trainee details page * handling missing application info, also adding download functionality * Update TrainneeDetails.tsx * adding way to send email and other adjustments * refining and fixing some issues * Update webpack.config.js * customizing way of sending email * refactoring code to fix issue related to code climate * fixing issue for deployment * fixing issues related to refactoring --------- Co-authored-by: MUREKEZI Ismael <[email protected]> Co-authored-by: MUGISHA Emmanuel <[email protected]> Co-authored-by: Mugisha <[email protected]> Co-authored-by: ISHIMWE Jean Baptiste <[email protected]> Co-authored-by: ceelogre <[email protected]> Co-authored-by: ManziPatrick <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> Ft search job post (#187) * ft(Add search): Add entry search * Will add user seach Job Functionalities --squashed commits * single page to view and search Jobs * will make jobs and search be on same page * updating functionality * Real time searching --------- Co-authored-by: Jmukakalisa <[email protected]> 154 crud application form (#167) * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card Add Verify Email (#179) Co-authored-by: vegetason <[email protected]> ft(Add search): Add entry search (#136) Co-authored-by: Jmukakalisa <[email protected]> Forget password #147 (#178) * fogetpassword * ft-forget password * reset and forget password * reset and forget password * reset and forget password * reset and forget password * reset password * reset update background * reset update background * reset update background * reset password * reset password * reset password * reset password * yarn.lock * Ft search job post (#187) * ft(Add search): Add entry search * Will add user seach Job Functionalities --squashed commits * single page to view and search Jobs * will make jobs and search be on same page * updating functionality * Real time searching --------- Co-authored-by: Jmukakalisa <[email protected]> * 154 crud application form (#167) * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card * Add Verify Email (#179) Co-authored-by: vegetason <[email protected]> * resolve comflit * resolve comflit * resolve comflit * resolve comflit --------- Co-authored-by: Aime Brues <[email protected]> Co-authored-by: Jmukakalisa <[email protected]> Co-authored-by: MUGISHA Joseph <[email protected]> Co-authored-by: Irakoze Paulin <[email protected]> Co-authored-by: vegetason <[email protected]> Ft edit, publish and unpublish jobs (#189) * fix: remove placeholder property * fix code & tell issue * will add ft for editing jobs --------- Co-authored-by: ceelogre <[email protected]> Fix fault alerts (#182) * correct error messages * work on resolving fault alerts remove a bug (#190) Co-authored-by: vegetason <[email protected]> Admin dashboard (#181) General search and filtration admin (#184) * general-search-admin * Will add results tab general search updates resolved conflicts admin general search updates fixing code climate issues * resolving conflicts --------- Co-authored-by: MUGISHA Joseph <[email protected]> * add applicant dashboard page * add dashboard cards * integrate with backend * fetch all data from their respective queries * remove console logs * update cohort types and query * fix routes * fix code climate * add graph * fix chart * delete yarn * fix graph and login * fix * trigger * revert --------- Co-authored-by: uwituzeb <[email protected]> Fix job Search (#199) Co-authored-by: vegetason <[email protected]> * feature: improve trainee details page (#172) * handling missing application info, also adding download functionality * fixing error related to download and refactoring * Update TrainneeDetails.tsx * handling issues related to deployment * Fix number can't be shared (#130) * #102 sidebar links review (#128) * fix: remove placeholder property * fix duplicate links --------- * Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- * #118 fx: builtinSuperAdminCreateProgram (#126) * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- * feature: improve trainee details page * handling missing application info, also adding download functionality * Update TrainneeDetails.tsx * adding way to send email and other adjustments * refining and fixing some issues * Update webpack.config.js * customizing way of sending email * refactoring code to fix issue related to code climate * fixing issue for deployment * fixing issues related to refactoring --------- Co-authored-by: MUREKEZI Ismael <[email protected]> Co-authored-by: MUGISHA Emmanuel <[email protected]> Co-authored-by: Mugisha <[email protected]> Co-authored-by: ISHIMWE Jean Baptiste <[email protected]> Co-authored-by: ceelogre <[email protected]> Co-authored-by: ManziPatrick <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> revert changes from develop (#205) fix:dev conflict issues (#207) added preferences page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bugs in Update trainee applicant
Summary
This PR adds validation for trainee applicant form fields and fixes issues related to its submission.
Related Issue
Fixes #131
Changes made
fields with the correct values from the current trainee data.
to the trainee’s information.
How to test
On this repo, checkout to branch
fix/update-trainee-info, then1.Go to the trainee applicants page -> click on three dots on random trainee -> click on edit -> trainee update form
2. Try submitting the form to check for validation messages
3. Enter invalid data in the form fields (phone, scores, etc) and check for validation messages.
4. Enter valid form data and submit to check for successful message of updating the trainee applicant information.
Screenshots
Notes
Additionally, this PR includes code refactoring to improve readability and maintainability.