Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for external links #22

Open
dpinn opened this issue Dec 16, 2020 · 2 comments
Open

False positives for external links #22

dpinn opened this issue Dec 16, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dpinn
Copy link

dpinn commented Dec 16, 2020

The following web item, which represents a link to our customer support portal, triggered some false positives in the CSRT report.

{
  "location": "admin_plugins_menu/admin-section",
  "weight": 200,
  "styleClasses": [
    "webitem",
    "system-present-webitem"
  ],
  "url": "https://projectbalm.atlassian.net/servicedesk/customer/portal/1",
  "tooltip": {
    "value": "Submit a support request"
  },
  "name": {
    "value": "Get support"
  },
  "key": "admin-support-link"
}

Requirement 5 - Authentication and Authorization of Application Resources

One or more endpoints returned a <400 status code without authentication information. This may indicate that your app is not performing authentication and authorization checks.

Requirement 12 - Referrer Policy

We did not detect the correct Referrer-Policy header on one or more endpoints.

Requirement 16 - App Name and Domain Branding Violations

Your app name or domain contained words that are not allowed

Maybe external links should be excluded from the checks?

@seanmarpo seanmarpo self-assigned this Dec 16, 2020
@seanmarpo seanmarpo added the bug Something isn't working label Dec 16, 2020
@seanmarpo
Copy link
Collaborator

Thanks for reporting this -- This is definitely a bug. I've tagged it as such, and we will get working on it.

@dziadyk-m
Copy link

I think that the same problem occures with Requirement 2 - Cache Control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants