confluence.add_user_to_group is wrong

[Mauwork]

atlassian-python-api/atlassian/confluence.py

Line 3062 in 42ed0b0

def add_user_to_group(self, username, group_name):

This function is using the wrong URL and it should be a "PUT" not a "POST" see:
https://docs.atlassian.com/ConfluenceServer/rest/8.2.0/#api/user/{username}/group/{groupName}-update
Fix that should work:

def add_user_to_group(self, username, group_name):
        """
        Add given user to a group

        :param username: str - username of user to add to group
        :param group_name: str - name of group to add user to
        :return: Current state of the group
        """
       url = f"rest/api/user/{username}/group/{group_name}"
       return self.put(url)

[gonchik]

Hi @Mauwork ,
first of all, thank you for your detection.
please send PR

[Mauwork]

PR: #1425

[Mauwork]

Can someone point me to a place where I can add a test to cover the method ? So that the pull request can be merged ?

[Spacetown]

In the test dir there are only two test files for confluence.

[Mauwork]

Thanks, I would have guessed that somewhere all the other methods are tested, but it does not seem to be the case. So I guess for previous commits the coverage was not a necessary criterion to merge a pull request ?

[gonchik]

Actually, it has been fixed. Sorry, forgot to follow-up.

meanwhile added remove_user_from_group method as well
9181fe1