Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address linter errors and warnings #48

Open
sajith opened this issue Aug 29, 2022 · 0 comments
Open

Address linter errors and warnings #48

sajith opened this issue Aug 29, 2022 · 0 comments
Assignees
Labels

Comments

@sajith
Copy link
Member

sajith commented Aug 29, 2022

Here's a summary (from this CI run, but it isn't really specific to that CI run in particular):

4     E111 indentation is not a multiple of 4
1     E265 block comment should start with '# '
94    E501 line too long (80 > 79 characters)
2     E711 comparison to None should be 'if cond is None:'
1     E712 comparison to True should be 'if cond is not True:' or 'if not cond:'
29    F401 'os' imported but unused
5     F403 'from swagger_server.messaging.topic_queue_consumer import *' used; unable to detect undefined names
10    F405 'TopicQueueConsumer' may be undefined, or defined from star imports: swagger_server.messaging.topic_queue_consumer, swagger_server.utils.db_utils
1     F811 redefinition of unused 'dataset' from line 1
14    F841 local variable 'e' is assigned to but never used
1     W291 trailing whitespace

Some of these could be cleaned up. The one one about overlong lines could be either ignored, or black and flake8 could be made to agree with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant