final touches

Author: athulp01

android/app/build.gradle

@@ -25,6 +25,13 @@ apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
 apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
 
+def keystoreProperties = new Properties()
+def keystorePropertiesFile = rootProject.file('key.properties')
+if (keystorePropertiesFile.exists()) {
+    keystoreProperties.load(new FileInputStream(keystorePropertiesFile))
+}
+
+
 android {
     compileSdkVersion 29
 
@@ -44,6 +51,15 @@ android {
         versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName
     }
+    
+    signingConfigs {
+       release {
+           keyAlias keystoreProperties['keyAlias']
+           keyPassword keystoreProperties['keyPassword']
+           storeFile keystoreProperties['storeFile'] ? file(keystoreProperties['storeFile']) : null
+           storePassword keystoreProperties['storePassword']
+       }
+   }
 
     buildTypes {
         release {

android/app/src/main/res/mipmap-hdpi/ic_launcher.png

@@ -1,25 +1,27 @@
 import 'package:flutter/material.dart';
 import 'comment.dart';
+import 'webview.dart';
 
-class HNStory {
-  HNStory(this.headline, this.author, this.votes, this.comments, this.time,
-      this.url, this.childrenID);
-  String headline, author, url;
+class HNItem {
+  HNItem(this.headline, this.author, this.votes, this.comments, this.time,
+      this.url, this.type, this.childrenID);
+  String headline, author, url, type;
   int votes, comments, id, score, time;
   List<dynamic> childrenID;
   List<HNComment> children;
 }
 
 class HNCard extends StatelessWidget {
-  final HNStory story;
+  final HNItem story;
+
   HNCard(this.story);
 
-  CommentPage page;
+  Widget page;
 
   Widget makeCard(BuildContext context) {
     var before = DateTime.now()
         .difference(DateTime.fromMillisecondsSinceEpoch(story.time * 1000));
-    String timeString = "${before.inHours} hours ago (${story.url}";
+    String timeString = "${before.inHours} hours ago";
     if (before.inHours < 1) {
       timeString = "${before.inMinutes} minutes ago";
     }
@@ -31,6 +33,16 @@ class HNCard extends StatelessWidget {
             color: Colors.white,
             child: InkWell(
                 onTap: () {
+                  if (story.type == "job")
+                    page = Scaffold(
+                        appBar: AppBar(
+                            title: Text(
+                              story.headline,
+                            ),
+                            backgroundColor: Color(0xffff6600)),
+                        body: Center(
+                          child: WebViewScreen(story.url),
+                        ));
                   if (page == null && story.childrenID != null) {
                     story.children = List(story.childrenID.length);
                     for (var i = 0; i < story.childrenID.length; i++) {
@@ -56,7 +68,8 @@ class HNCard extends StatelessWidget {
                             color: Colors.black,
                             fontFamily: "Helvetica"),
                       ),
-                      subtitle: Text("$timeString by ${this.story.author}")),
+                      subtitle: Text(
+                          "$timeString by ${this.story.author} (${story.url})")),
                   Row(
                     children: [
                       Container(
@@ -80,7 +93,7 @@ class HNCard extends StatelessWidget {
                                   color: Colors.green,
                                 ),
                                 onPressed: null),
-                            Text('${this.story.comments}',
+                            Text('${this.story.comments ?? 0}',
                                 style: TextStyle(fontWeight: FontWeight.w600))
                           ])),
                     ],

android/app/src/main/res/mipmap-mdpi/ic_launcher.png

@@ -16,27 +16,31 @@ class HNComment {
 }
 
 class CommentPage extends StatefulWidget {
-  final HNStory _story;
+  final HNItem story;
+  List<Widget> cards;
+  int counter = 0;
 
-  CommentPage(this._story);
+  CommentPage(this.story) {
+    cards = new List(story.comments);
+  }
 
-  CommentPageState createState() => CommentPageState(_story);
+  @override
+  CommentPageState createState() => new CommentPageState(story);
 }
 
 class CommentPageState extends State<CommentPage> {
-  final HNStory _story;
-  List<Widget> _cards;
+  final HNItem _story;
 
-  CommentPageState(this._story) {
-    _cards = new List(_story.comments);
-    getComments();
-  }
+  CommentPageState(this._story);
 
   void initState() {
     super.initState();
-    var loading = _makeCard("...", "...", 0, 0);
-    for (int i = 0; i < _story.comments; i++) {
-      _cards[i] = loading;
+    if (widget.counter == 0) {
+      getComments();
+      var loading = _makeCard("...", "...", 0, 0);
+      for (int i = 0; i < _story.comments; i++) {
+        widget.cards[i] = loading;
+      }
     }
   }
 
@@ -60,7 +64,6 @@ class CommentPageState extends State<CommentPage> {
   }
 
   void getComments() async {
-    int j = 0;
     for (var comment in _story.children) {
       comment.future = HNAPI.fetchItem(comment.id);
       ListQueue<HNComment> stack = new ListQueue();
@@ -69,13 +72,21 @@ class CommentPageState extends State<CommentPage> {
         HNComment top = stack.last;
         stack.removeLast();
         var res = await top.future;
-        setState(() {
-          if (j < _story.comments) {
-            _cards[j] = _makeCard(res["text"] ?? "deleted", res["by"] ?? "?",
-                res['time'], top.left);
-            j++;
+        if (mounted) {
+          setState(() {
+            if (widget.counter < _story.comments) {
+              widget.cards[widget.counter] = _makeCard(res["text"] ?? "deleted",
+                  res["by"] ?? "?", res['time'], top.left);
+              widget.counter++;
+            }
+          });
+        } else {
+          if (widget.counter < _story.comments) {
+            widget.cards[widget.counter] = _makeCard(res["text"] ?? "deleted",
+                res["by"] ?? "?", res['time'], top.left);
+            widget.counter++;
           }
-        });
+        }
         if (res['kids'] != null) {
           top.children = new List(res["kids"].length);
           for (int i = 0; i < res["kids"].length; i++) {
@@ -94,23 +105,23 @@ class CommentPageState extends State<CommentPage> {
         length: 2,
         child: Scaffold(
           appBar: AppBar(
-            title: Text("${_story.headline}"),
+            title: Text(_story.headline),
             backgroundColor: Color(0xffff6600),
             bottom: TabBar(tabs: [
-              Tab(text: "Website"),
               Tab(text: "Comments"),
+              Tab(text: "Website"),
             ]),
           ),
           body: Center(
               child: TabBarView(children: [
-            WebViewScreen(_story.url),
             Container(
                 decoration: BoxDecoration(color: Colors.grey[200]),
                 child: ListView.builder(
                     itemBuilder: (context, index) {
-                      return _cards[index];
+                      return widget.cards[index];
                     },
-                    itemCount: _cards.length)),
+                    itemCount: widget.cards.length)),
+            WebViewScreen(_story.url),
           ])),
         ));
   }

android/app/src/main/res/mipmap-xhdpi/ic_launcher.png

@@ -6,9 +6,10 @@ class HNTopState extends State<HNTop> {
   Future<Map<String, dynamic>> items;
   Future<List<dynamic>> itemIDs;
   List<HNCard> cards;
-  List<HNStory> stories;
+  List<HNItem> stories;
 
-  HNCard loading = new HNCard(new HNStory('...', '...', 0, 0, 0, "", null));
+  HNCard loading =
+      new HNCard(new HNItem('...', '...', 0, 0, 0, "", "story", null));
 
   @override
   void initState() {
@@ -35,13 +36,14 @@ class HNTopState extends State<HNTop> {
                         future: item,
                         builder: (context, snapshot) {
                           if (snapshot.hasData) {
-                            stories[index] = HNStory(
+                            stories[index] = HNItem(
                                 snapshot.data['title'],
                                 snapshot.data['by'],
                                 snapshot.data['score'],
                                 snapshot.data['descendants'],
                                 snapshot.data['time'],
                                 snapshot.data['url'],
+                                snapshot.data["type"],
                                 snapshot.data['kids']);
                             cards[index] = new HNCard(stories[index]);
                             return cards[index];