Skip to content

Commit 3ce4dc7

Browse files
committed
update todo, fix favicons, fix auto deploy on pr in gh action.
1 parent d229423 commit 3ce4dc7

File tree

10 files changed

+15
-3
lines changed

10 files changed

+15
-3
lines changed

.github/workflows/deploy-to-ghpages.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
branches:
66
- main
7-
pull_request:
87

98
jobs:
109
deploy:

_src/_includes/base.njk

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
<meta charset="utf-8" />
55
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
66
<title>{{ title or metadata.title }}</title>
7+
<link rel="icon" type="image/png" href="/favicon-96x96.png" sizes="96x96" />
8+
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
9+
<link rel="shortcut icon" href="/favicon.ico" />
10+
<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" />
711
<meta
812
name="description"
913
content="{{ description or metadata.description }}"
13.3 KB
Loading
5.27 KB
Loading

_src/assets/favicons/favicon.ico

14.7 KB
Binary file not shown.

_src/assets/favicons/favicon.svg

Lines changed: 3 additions & 0 deletions
Loading
14.6 KB
Loading
73.5 KB
Loading

eleventy.config.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,12 @@ export default function (eleventyConfig) {
108108
});
109109
eleventyConfig.setInputDirectory("_src");
110110
eleventyConfig.addPassthroughCopy("_src/assets");
111+
eleventyConfig.addPassthroughCopy({
112+
"_src/assets/favicons/favicon-96x96.png": "/favicon-96x96.png",
113+
"_src/assets/favicons/favicon.svg": "/favicon.svg",
114+
"_src/assets/favicons/favicon.ico": "/favicon.ico",
115+
"_src/assets/favicons/apple-touch-icon.png": "/apple-touch-icon.png",
116+
});
111117
eleventyConfig.addPlugin(eleventyNavigationPlugin);
112118
eleventyConfig.addPlugin(eleventyImageTransformPlugin);
113119
eleventyConfig.addPlugin(sitemap, {

todo.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
- My role & tools used (e.g. “Designed a serverless ETL pipeline using AWS Lambda and Step Functions”)
2626
- Impact or outcome (e.g. “Reduced data latency by 80%”)
2727
- Blog
28-
- Intro to integration-sandbox
29-
- Solve problem with Fluxygen
28+
~~ - Intro to integration-sandbox~~
29+
~~ - Solve problem with Fluxygen~~
3030
- Solve problem with Azure Logic Apps
3131
- Solve problem with n8n
3232
~~- Contact~~

0 commit comments

Comments
 (0)