Skip to content

Commit b054e06

Browse files
committed
chore: rename AccessModifiers to DeclarationModifiers and add a more correct AccessModifiers
1 parent 5e3f257 commit b054e06

File tree

52 files changed

+249
-198
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+249
-198
lines changed

src/Atc.CodeGeneration.CSharp/Content/AccessModifiers.cs

Lines changed: 6 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -7,51 +7,18 @@ public enum AccessModifiers
77
[Description("public")]
88
Public,
99

10-
[Description("public async")]
11-
PublicAsync,
12-
13-
[Description("public static")]
14-
PublicStatic,
15-
16-
[Description("public static implicit operator")]
17-
PublicStaticImplicitOperator,
18-
19-
[Description("public class")]
20-
PublicClass,
21-
22-
[Description("public partial class")]
23-
PublicPartialClass,
24-
25-
[Description("public static class")]
26-
PublicStaticClass,
27-
28-
[Description("public sealed class")]
29-
PublicSealedClass,
30-
31-
[Description("public interface")]
32-
PublicInterface,
33-
34-
[Description("public partial interface")]
35-
PublicPartialInterface,
36-
37-
[Description("public static interface")]
38-
PublicStaticInterface,
39-
40-
[Description("public record")]
41-
PublicRecord,
42-
43-
[Description("public record struct")]
44-
PublicRecordStruct,
45-
4610
[Description("private")]
4711
Private,
4812

49-
[Description("private async")]
50-
PrivateAsync,
51-
5213
[Description("protected")]
5314
Protected,
5415

5516
[Description("internal")]
5617
Internal,
18+
19+
[Description("protected internal")]
20+
ProtectedInternal,
21+
22+
[Description("private protected")]
23+
PrivateProtected,
5724
}
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
namespace Atc.CodeGeneration.CSharp.Content;
2+
3+
public enum DeclarationModifiers
4+
{
5+
None,
6+
7+
[Description("public")]
8+
Public,
9+
10+
[Description("public async")]
11+
PublicAsync,
12+
13+
[Description("public static")]
14+
PublicStatic,
15+
16+
[Description("public static implicit operator")]
17+
PublicStaticImplicitOperator,
18+
19+
[Description("public class")]
20+
PublicClass,
21+
22+
[Description("public partial class")]
23+
PublicPartialClass,
24+
25+
[Description("public static class")]
26+
PublicStaticClass,
27+
28+
[Description("public sealed class")]
29+
PublicSealedClass,
30+
31+
[Description("public interface")]
32+
PublicInterface,
33+
34+
[Description("public partial interface")]
35+
PublicPartialInterface,
36+
37+
[Description("public static interface")]
38+
PublicStaticInterface,
39+
40+
[Description("public record")]
41+
PublicRecord,
42+
43+
[Description("public record struct")]
44+
PublicRecordStruct,
45+
46+
[Description("public partial record")]
47+
PublicPartialRecord,
48+
49+
[Description("public partial record struct")]
50+
PublicPartialRecordStruct,
51+
52+
[Description("private")]
53+
Private,
54+
55+
[Description("private async")]
56+
PrivateAsync,
57+
58+
[Description("protected")]
59+
Protected,
60+
61+
[Description("internal")]
62+
Internal,
63+
}

src/Atc.CodeGeneration.CSharp/Content/Factories/ClassParametersFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public static ClassParameters Create(
1313
Namespace: @namespace,
1414
DocumentationTags: null,
1515
Attributes: new List<AttributeParameters> { attribute },
16-
usePartialClass ? AccessModifiers.PublicPartialClass : AccessModifiers.PublicClass,
16+
usePartialClass ? DeclarationModifiers.PublicPartialClass : DeclarationModifiers.PublicClass,
1717
ClassTypeName: classTypeName,
1818
GenericTypeName: null,
1919
InheritedClassTypeName: null,

src/Atc.CodeGeneration.CSharp/Content/Factories/EnumParametersFactory.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public static EnumParameters Create(
1414
Namespace: @namespace,
1515
DocumentationTags: documentationTags,
1616
Attributes: attributes,
17-
AccessModifier: AccessModifiers.Public,
17+
DeclarationModifier: DeclarationModifiers.Public,
1818
EnumTypeName: enumTypeName,
1919
UseFlags: false,
2020
EnumValuesParametersFactory.Create(enumNames));
@@ -31,7 +31,7 @@ public static EnumParameters Create(
3131
Namespace: @namespace,
3232
DocumentationTags: documentationTags,
3333
Attributes: attributes,
34-
AccessModifier: AccessModifiers.Public,
34+
DeclarationModifier: DeclarationModifiers.Public,
3535
EnumTypeName: enumTypeName,
3636
UseFlags: DetermineIfFlagsAttributeShouldBeUsed(enumNameValues),
3737
EnumValuesParametersFactory.Create(enumNameValues));

src/Atc.CodeGeneration.CSharp/Content/Factories/InterfaceParametersFactory.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public static InterfaceParameters Create(
1212
Namespace: @namespace,
1313
DocumentationTags: null,
1414
Attributes: new List<AttributeParameters> { attribute },
15-
AccessModifiers.Public,
15+
DeclarationModifiers.Public,
1616
InterfaceTypeName: interfaceTypeName,
1717
InheritedInterfaceTypeName: null,
1818
Properties: null,
@@ -28,7 +28,7 @@ public static InterfaceParameters Create(
2828
Namespace: @namespace,
2929
DocumentationTags: null,
3030
Attributes: attributes,
31-
AccessModifiers.PublicInterface,
31+
DeclarationModifiers.PublicInterface,
3232
InterfaceTypeName: interfaceTypeName,
3333
InheritedInterfaceTypeName: null,
3434
Properties: null,

src/Atc.CodeGeneration.CSharp/Content/Generators/GenerateContentForClass.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public string Generate()
2727
parameters.DocumentationTags,
2828
parameters.Attributes));
2929

30-
sb.Append($"{parameters.AccessModifier.GetDescription()} {parameters.ClassTypeName}");
30+
sb.Append($"{parameters.DeclarationModifier.GetDescription()} {parameters.ClassTypeName}");
3131
if (!string.IsNullOrEmpty(parameters.GenericTypeName))
3232
{
3333
sb.Append($"<{parameters.GenericTypeName}>");

src/Atc.CodeGeneration.CSharp/Content/Generators/GenerateContentForEnum.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public string Generate()
3434
sb.AppendLine("[JsonConverter(typeof(JsonStringEnumConverter))]");
3535
}
3636

37-
sb.Append($"{parameters.AccessModifier.GetDescription()} enum ");
37+
sb.Append($"{parameters.DeclarationModifier.GetDescription()} enum ");
3838
sb.AppendLine($"{parameters.EnumTypeName}");
3939

4040
sb.AppendLine("{");

src/Atc.CodeGeneration.CSharp/Content/Generators/GenerateContentForInterface.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public string Generate()
2626
parameters.DocumentationTags,
2727
parameters.Attributes));
2828

29-
sb.Append($"{parameters.AccessModifier.GetDescription()} ");
29+
sb.Append($"{parameters.DeclarationModifier.GetDescription()} ");
3030
if (string.IsNullOrEmpty(parameters.InheritedInterfaceTypeName))
3131
{
3232
sb.AppendLine($"{parameters.InterfaceTypeName}");

src/Atc.CodeGeneration.CSharp/Content/Generators/GenerateContentForRecords.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ public string Generate()
3434
recordParameters.Parameters.Any(x => x.IsGenericListType &&
3535
x.TypeName.Equals("T", StringComparison.Ordinal)))
3636
{
37-
sb.Append($"{recordParameters.AccessModifier.GetDescription()} {recordParameters.Name}<T>");
37+
sb.Append($"{recordParameters.DeclarationModifier.GetDescription()} {recordParameters.Name}<T>");
3838
}
3939
else
4040
{
41-
sb.Append($"{recordParameters.AccessModifier.GetDescription()} {recordParameters.Name}");
41+
sb.Append($"{recordParameters.DeclarationModifier.GetDescription()} {recordParameters.Name}");
4242
}
4343

4444
if (recordParameters.Parameters is null ||

src/Atc.CodeGeneration.CSharp/Content/Generators/Internal/GenerateContentWriter.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public string GenerateConstructor(
5353

5454
var sb = new StringBuilder();
5555

56-
sb.AppendAccessModifier(4, parameters.AccessModifier);
56+
sb.AppendDeclarationModifier(4, parameters.DeclarationModifier);
5757

5858
if (string.IsNullOrEmpty(parameters.GenericTypeName))
5959
{
@@ -181,9 +181,9 @@ public string GenerateProperty(
181181
}
182182

183183
sb.Append(" ");
184-
if (parameters.AccessModifier != AccessModifiers.None)
184+
if (parameters.DeclarationModifier != DeclarationModifiers.None)
185185
{
186-
sb.AppendAccessModifier(parameters.AccessModifier);
186+
sb.AppendDeclarationModifier(parameters.DeclarationModifier);
187187
}
188188

189189
sb.AppendTypeAndName(parameters.GenericTypeName, parameters.TypeName, parameters.IsNullableType, parameters.Name);
@@ -261,9 +261,9 @@ public string GenerateMethod(
261261
}
262262

263263
sb.Append(" ");
264-
if (parameters.AccessModifier != AccessModifiers.None)
264+
if (parameters.DeclarationModifier != DeclarationModifiers.None)
265265
{
266-
sb.AppendAccessModifier(parameters.AccessModifier);
266+
sb.AppendDeclarationModifier(parameters.DeclarationModifier);
267267
}
268268

269269
if (string.IsNullOrEmpty(parameters.ReturnTypeName))
@@ -306,7 +306,7 @@ public string GenerateMethod(
306306
useCommaForEndChar);
307307
}
308308

309-
if (parameters.AccessModifier == AccessModifiers.None)
309+
if (parameters.DeclarationModifier == DeclarationModifiers.None)
310310
{
311311
sb.Append(';');
312312
}

0 commit comments

Comments
 (0)