chore: fix some null checks, use OpenApiDataTypeConstants.Object instead of string-version

Author: davidkallesen

src/Atc.Rest.ApiGenerator.Framework/Factories/Parameters/Client/ContentGeneratorClientParameterParametersFactory.cs

@@ -109,7 +109,7 @@ private static void AppendParametersFromBody(
         {
             requestBodyType = "IFormFile";
         }
-        else if (requestSchema.Items is not null)
+        else if (requestSchema.Items?.Reference is not null)
         {
             requestBodyType = requestSchema.Items.Reference.Id.PascalCase(ApiOperationExtractor.ModelNameSeparators, removeSeparators: true);
         }

src/Atc.Rest.ApiGenerator.Framework/Factories/Parameters/ServerClient/ContentGeneratorServerClientEnumParametersFactory.cs

@@ -43,7 +43,7 @@ public static EnumParameters Create(
             {
                 case 1:
                     result.Add(
-                        key: sa[0].Trim(),
+                        key: sa[0].Trim().Replace(":", "-", StringComparison.CurrentCulture),
                         value: null);
                     break;
                 case 2:

src/Atc.Rest.ApiGenerator.Framework/Factories/Parameters/ServerClient/ContentGeneratorServerClientModelParametersFactory.cs

@@ -179,7 +179,13 @@ private static bool GetRequired(
                     : $"{schema.GetModelName()}.{value.EnsureFirstCharacterToUpper()}";
             }
 
-            return schema.Default.GetDefaultValueAsString();
+            if (schema.Type is not null &&
+                schema.Type != "object")
+            {
+                return schema.Default.GetDefaultValueAsString();
+            }
+
+            return null;
         }
 
         if (NameConstants.List.Equals(dataTypeForList, StringComparison.Ordinal))
@@ -252,7 +258,7 @@ private static List<PropertyParameters> ExtractPropertiesParameters(
 
                     if ("Object".Equals(dataType, StringComparison.Ordinal))
                     {
-                        dataType = "object";
+                        dataType = OpenApiDataTypeConstants.Object;
                     }
                 }
                 else
@@ -269,7 +275,7 @@ private static List<PropertyParameters> ExtractPropertiesParameters(
                         }
                         else
                         {
-                            dataType = "object";
+                            dataType = OpenApiDataTypeConstants.Object;
                         }
                     }
                 }
@@ -450,7 +456,7 @@ private static List<ParameterBaseParameters> ExtractRecordParameterBaseParameter
 
                     if ("Object".Equals(dataType, StringComparison.Ordinal))
                     {
-                        dataType = "object";
+                        dataType = OpenApiDataTypeConstants.Object;
                     }
                 }
                 else
@@ -467,7 +473,7 @@ private static List<ParameterBaseParameters> ExtractRecordParameterBaseParameter
                         }
                         else
                         {
-                            dataType = "object";
+                            dataType = OpenApiDataTypeConstants.Object;
                         }
                     }
                 }