Merge pull request #98 from atc-net/bug/49-nullable-properties-tostring

The ToString on models now print the count of collections

Author: davidkallesen

src/Atc.Rest.ApiGenerator/ProjectSyntaxFactories/SyntaxMethodDeclarationFactory.cs

@@ -65,9 +65,17 @@ public static MethodDeclarationSyntax CreateInterfaceMethod(string parameterType
                 foreach (var schema in apiSchemaProperties)
                 {
                     var name = schema.Key.EnsureFirstCharacterToUpper();
+                    var isArray = schema.Value.Type == OpenApiDataTypeConstants.Array;
                     var hasAnyProperties = schema.Value.HasAnyProperties();
 
-                    if (!hasAnyProperties)
+                    if (isArray)
+                    {
+                        content.Add(SyntaxInterpolatedFactory.CreateNameOf(name));
+                        content.Add(SyntaxInterpolatedFactory.StringText(".Count: "));
+                        var countCoalesceExpression = SyntaxFactory.ParseExpression($"{name}?.Count ?? 0");
+                        content.Add(SyntaxFactory.Interpolation(countCoalesceExpression));
+                    }
+                    else if (!hasAnyProperties)
                     {
                         content.Add(SyntaxInterpolatedFactory.CreateNameOf(name));
                         content.Add(SyntaxInterpolatedFactory.StringTextColon());

test/Atc.Rest.ApiGenerator.Tests/SyntaxGenerators/Api/XUnitTestData/ContractModel/collectionToStringCount.verified.cs

@@ -0,0 +1,30 @@
+using System.CodeDom.Compiler;
+using System.Collections.Generic;
+
+//------------------------------------------------------------------------------
+// This code was auto-generated by ApiGenerator x.x.x.x.
+//
+// Changes to this file may cause incorrect behavior and will be lost if
+// the code is regenerated.
+//------------------------------------------------------------------------------
+namespace TestProject.AtcTest.Contracts.Test
+{
+    /// <summary>
+    /// Test component description.
+    /// </summary>
+    [GeneratedCode("ApiGenerator", "x.x.x.x")]
+    public class TestComponent
+    {
+        public List<string> Foos { get; set; } = new List<string>();
+
+        public List<string> NullableFoos { get; set; } = new List<string>();
+
+        /// <summary>
+        /// Converts to string.
+        /// </summary>
+        public override string ToString()
+        {
+            return $"{nameof(Foos)}.Count: {Foos?.Count ?? 0}, {nameof(NullableFoos)}.Count: {NullableFoos?.Count ?? 0}";
+        }
+    }
+}

test/Atc.Rest.ApiGenerator.Tests/SyntaxGenerators/Api/XUnitTestData/ContractModel/collectionToStringCount.yaml

@@ -0,0 +1,18 @@
+openapi: 3.0.0
+components:
+  schemas:
+    TestComponent:
+      title: TestComponent
+      description: 'Test component description'
+      type: object
+      properties:
+        foos:
+          type: array
+          required: true
+          items:
+            type: string
+        nullableFoos:
+          type: array
+          nullable: true
+          items:
+            type: string

test/Atc.Rest.ApiGenerator.Tests/SyntaxGenerators/Api/XUnitTestData/ContractModel/requiredArrayComponent.verified.cs

@@ -24,7 +24,7 @@ public class RequiredArrayComponent
         /// </summary>
         public override string ToString()
         {
-            return $"{nameof(MyItems)}: {MyItems}";
+            return $"{nameof(MyItems)}.Count: {MyItems?.Count ?? 0}";
         }
     }
 }