-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some G2 worlds can not be parsed. #42
Comments
Okay I have located the issue. In I don't think this is easily fixable because VOBs with different class names may have different versions refering to the class being used. Edit: I have extracted all possible class names and corresponding versions for G1 and G2:
|
I propose the following solution: use the method below to determine if a chunk should be parsed using the G2 base static bool isG2Vob(uint32_t version, WorldVersion world) {
switch (version) {
case 52224:
case 5505:
case 193:
case 39168:
case 33793:
return true;
default:
return world != WorldVersion::VERSION_G1_08k;
}
} Then replace this check with the above method. This is a crude solution and may need further consideration especially because |
Some Gothic 2 worlds (see below) can not be parsed. The following
std::runtime_error
is thrown:Value name does not match expected name. Value:VISUALANIMODE Expected: CDSTATIC
The worlds that cannot be parsed are:
The text was updated successfully, but these errors were encountered: