Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the studio-next and studio apps #1134

Closed
Shurtu-gal opened this issue Sep 13, 2024 · 13 comments
Closed

Merge the studio-next and studio apps #1134

Shurtu-gal opened this issue Sep 13, 2024 · 13 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Shurtu-gal
Copy link
Collaborator

The studio-next folder was created for migrating to next.js. As the migration is complete now, it is time to remove the studio folder to decrease the redundancy.

Steps:

  • Remove the studio folder.
  • Check if there are any regressive problems or differences in the studio-next app as compared to the currently deployed site.
  • @fmvilas I suppose we will have to edit the domain tracking at netlify as well.
@Shurtu-gal Shurtu-gal added the enhancement New feature or request label Sep 13, 2024
@Shurtu-gal
Copy link
Collaborator Author

/gfi

@Shurtu-gal
Copy link
Collaborator Author

/help

@Shurtu-gal Shurtu-gal added the good first issue Good for newcomers label Sep 13, 2024
@asyncapi-bot
Copy link
Contributor

Hey @Shurtu-gal, your message doesn't follow the requirements, you can try /help.

@asyncapi-bot
Copy link
Contributor

Hello, @Shurtu-gal! 👋🏼

I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

@Shurtu-gal
Copy link
Collaborator Author

Tagging for visibility @Amzani @fmvilas.

@aeworxet
Copy link
Contributor

Please do this task only after #1094 is merged.

Besides, special attention must be paid to paths, naming, and versioning:
https://github.com/asyncapi/studio/blob/master/apps/studio/package.json#L2
https://github.com/asyncapi/studio/blob/master/apps/studio-next/package.json#L2

@Shurtu-gal
Copy link
Collaborator Author

Please do this task only after #1094 is merged.

Sure. Just wanted to initiate it before we move along.

@aeworxet
Copy link
Contributor

The migrated version also might get immediately broken due to #1094 (comment).

@aeworxet
Copy link
Contributor

#1094 was merged, so pay attention to this change: #1094 (comment).

@aeworxet
Copy link
Contributor

FYI
Hard-locked the @asyncapi/converter on version 1.5.0 during handling incident #1138.

@aeworxet
Copy link
Contributor

#1120 was merged just now.

@prashantrai-30
Copy link

Hey @Shurtu-gal,can you assign this to me.

@Shurtu-gal
Copy link
Collaborator Author

Hey @prashantrai-30 already a PR has resolved this. I forgot to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

4 participants