Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in bundler. Schema properties are wrong in at least 2.0.0-rc1-without-$id.json #454

Open
smoya opened this issue Nov 26, 2023 · 8 comments · Fixed by #537
Open

Bug in bundler. Schema properties are wrong in at least 2.0.0-rc1-without-$id.json #454

smoya opened this issue Nov 26, 2023 · 8 comments · Fixed by #537
Labels
bug Something isn't working stale

Comments

@smoya
Copy link
Member

smoya commented Nov 26, 2023

Describe the bug

Investigating some schema validation errors given at #452, I found out that most of the properties from the schema definition in 2.0.0-rc1-without-$id.json are pointing to #/definitions/json-schema-draft-07-schema. For example:

"minimum": {
  "$ref": "#/definitions/json-schema-draft-07-schema"
},

This is wrong because of two things:

  1. It should not point to the draft-07 schema but rather draft-04, according to the 2.0.0-rc1.json. For example:
"minimum": {
  "$ref": "http://json-schema.org/draft-04/schema#/properties/minimum"
},
  1. It should point to the right properties of the referred schema, not to the schema itself. Meaning #/properties/<the-property> is missing from that pointer.

Since the without-$id files are generated by our bundler , I don't know about the magnitude of this issue. We should definitely check if other schemas are affected as well.

@smoya smoya added the bug Something isn't working label Nov 26, 2023
@smoya smoya changed the title Schema properties are wrong in at least 2.0.0-rc1-without-$id.json Bug in bundler. Schema properties are wrong in at least 2.0.0-rc1-without-$id.json Nov 26, 2023
@smoya
Copy link
Member Author

smoya commented Nov 27, 2023

@derberg
Copy link
Member

derberg commented Nov 28, 2023

for the record, correct draft for any v2 version is draft 7 and not 4

AnimeshKumar923 added a commit to AnimeshKumar923/asyncapi-spec-json-schemas that referenced this issue Nov 28, 2023
Changes:

- added the function temporarily to avoid validation failure
  due to these two files

- The schemas version are incorrect in these and needs to be fixed

Issue concerning fixing of the described issue:
1. asyncapi#454
2. asyncapi#455
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@smoya
Copy link
Member Author

smoya commented May 22, 2024

It is not yet completed until next major version gets released #541

@smoya smoya reopened this May 22, 2024
@jonaslagoni
Copy link
Member

@smoya why have it open and cluttering issues page when it will eventually be released 🤷‍♂️

@smoya
Copy link
Member Author

smoya commented May 22, 2024

@smoya why have it open and cluttering issues page when it will eventually be released 🤷‍♂️

Because the issue is still happening in last release and master branch. Someone could come here and look for issues regarding this bug and see it was closed and, in the best scenario, will lose time understanding that, yeah, it got fixed but not released yet.

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants