Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fetch 2.6.0 security vulnerability in package.json #202

Open
kulnor opened this issue Apr 7, 2023 · 2 comments
Open

node-fetch 2.6.0 security vulnerability in package.json #202

kulnor opened this issue Apr 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@kulnor
Copy link

kulnor commented Apr 7, 2023

Describe the bug

Just installed asyncapi CLI and used this template to generate a new server project. Noticed an issue in the package.json as a security vulnerability is being reported for node-fetch 2.6.0. The quick fix is to update to the latest version, which is currently 3.3.1 (assuming this is compatible with generated code)

How to Reproduce

  • Generate a simple project from a asyncapi.yaml file using this template
  • Open the project in Visual Studio Code
  • Open the package.json file
    image

How to fix

In package.json change
"node-fetch": "2.6.0",
to
"node-fetch": "3.3.1",

Expected behavior

No issue should be reported in a freshly generated project.

@kulnor kulnor added the bug Something isn't working label Apr 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Apr 24, 2023

Thanks a lot for this issue. This is not very critical for the template as tbh I don't think anyone is using this lambda extension that requires fetch. Nevertheless we need to bump the dependency. Do you want to open a PR?

kaushik-rishi pushed a commit to kaushik-rishi/nodejs-template that referenced this issue Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants