Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve originalInput property #1786

Closed
jonaslagoni opened this issue Feb 12, 2024 · 1 comment
Closed

Improve originalInput property #1786

jonaslagoni opened this issue Feb 12, 2024 · 1 comment
Labels
enhancement New feature or request stale

Comments

@jonaslagoni
Copy link
Member

jonaslagoni commented Feb 12, 2024

Reason/Context

Right now the originalInput property in the MetaModel is a relic that over-served its purpose in its current form.

Here are the current problems with it:

  • It's impossible to determine the type of the input that builds the model. I.e. it could be an AsyncAPI Schema, or Avro, the only way to know is for each time you access it determine it by interpretation.
  • If you do end up interpreting the value it's near impossible to know the type as it's all internal in Modelina without having any rules on what it may be.

These two problems make it hard to use the values when needed in the presets.

Ideally, any important values should be part of the MetaModels, but the originalInput should always be there as a backup for users. It should also be possible for users to extend the originalInput types to custom ones in order to support that users can create their own models from scratch.

Therefore I propose we change this in the next major version as this will be a breaking change.

@jonaslagoni jonaslagoni added the enhancement New feature or request label Feb 12, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 12, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant