Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @stoplight/json-ref-resolver instead of @apidevtools/json-schema-ref-parser #146

Closed
kennethaasan opened this issue Dec 19, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@kennethaasan
Copy link

Reason/Context

The parser has already done this change because @apidevtools/json-schema-ref-parser does not have a maintainer.

@kennethaasan kennethaasan added the enhancement New feature or request label Dec 19, 2023
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Member

derberg commented Dec 19, 2023

Hey, just for the context in case you are not aware

The stoplight resolver is archived project https://github.com/stoplightio/json-ref-resolver and tbh parser should never start using it and hope maintainers will drop it -> asyncapi/parser-js#761

afaik https://github.com/APIDevTools/json-schema-ref-parser has a new maintainer that after official call out for maintainers joined and even rewrote the project to TS.

@kennethaasan
Copy link
Author

That's awesome. I wasn't aware and just spotted the difference. I commented asyncapi/parser-js#761

Copy link
Member

derberg commented Dec 19, 2023

Thanks @kennethaasan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants