Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handled the document object being undefined in the parser result. #912

Closed

Conversation

ashmit-coder
Copy link

Description

Changes proposed in this pull request:

  • Handled the document object being undefined.
  • In the changes proposed the code section throws an error when the document object is undefined.

Related issue(s)

Fixes: #874

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ashmit-coder ashmit-coder changed the title handled the document object being undefined in the parser result. fix: handled the document object being undefined in the parser result. Feb 5, 2024
@ashmit-coder
Copy link
Author

Screenshot from 2024-02-05 18-24-41

This is how the erros currently look, if the method is approved , proper css and formating can be added to the errror messages.

@ashmit-coder
Copy link
Author

Hey @magicmatatjahu or @derberg I was enhancing the error message but am unable to apply any css to the above text that is being rendered

@ashmit-coder
Copy link
Author

Also I would like to know if this is an upstream error or we should handle it here itself and make changes as per the latest state of the parser output

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Jun 13, 2024

can you update PR with latest master, and resolve conflicts please 🙏🏼

Copy link

sonarcloud bot commented Jun 25, 2024

@ibishal
Copy link

ibishal commented Jul 12, 2024

can you update PR with latest master, and resolve conflicts please 🙏🏼

cc @ashmit-coder

@derberg
Copy link
Member

derberg commented Jul 27, 2024

no response in 2 weeks.

closing the PR. @ashmit-coder feel free to open a new PR with resolved conflicts. I'm just closing it for cleanup purposes to not have open and not active PR open forever

@derberg derberg closed this Jul 27, 2024
@ashmit-coder
Copy link
Author

no response in 2 weeks.

closing the PR. @ashmit-coder feel free to open a new PR with resolved conflicts. I'm just closing it for cleanup purposes to not have open and not active PR open forever

Hey sorry @derberg I was busy with other stuff. I will try to create a new PR during the GSOC period itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option "errors: true" shows empty/blank page when document has errors
3 participants