-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update isomorphic-dompurify and remove @types/highlight.js #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@batyshkaLenin thanks, can you share why these updates : |
@derberg @types/highlight.js I removed because this library has its own type declarations. isomorphic-dompurify I updated because, every time I installed dependencies in my project, there was a warning that one of its dependencies had a CVE (I don't remember which one, I made this PR over two weeks ago). @types/dompurify I updated to not have conflicting type versions in package-json, because isomorphic-dompurify has a different type version. In a broader view, there was no big need to upgrade, I wanted to get rid of the warning when installing dependencies in my project. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, since we update dev dependency, we should release patch, this is why I changed the prefix to fix:
/rtm |
🎉 This PR is included in version 2.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes proposed in this pull request: