Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab navigation issue in Tab component #1024

Conversation

NEMYSESx
Copy link

Fixes: #1008
The condition in the onClick handler of TabLink has been fixed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@asyncapi-bot
Copy link
Contributor

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "Fix tab navigation issue in Tab component". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

sonarcloud bot commented Jul 3, 2024

1 similar comment
Copy link

sonarcloud bot commented Jul 3, 2024

@NEMYSESx
Copy link
Author

Hey!! Can you review the code and merge it plz
It's my first open source contribution. My confidence will boost if u consider reviewing it

@ibishal
Copy link

ibishal commented Jul 12, 2024

Hey!! Can you review the code and merge it plz It's my first open source contribution. My confidence will boost if u consider reviewing it

@NEMYSESx follow the PR naming conventionshere, in your case add a fix: in start of your PR name

@ibishal
Copy link

ibishal commented Jul 12, 2024

Dont push the package-lock.json in the PR, and if you can also include a video of the working solution

@derberg
Copy link
Member

derberg commented Jul 25, 2024

closing as there is no response and PR quality is anyway far from following basic requirements

@derberg derberg closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 bug : navigation tab is not working properly
4 participants