fix: render specs that contain oauth2 password flow only #1023
Conversation
pltod2
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
1 similar comment
|
|
@derberg Do you have any idea when this PR can be looked at and merged? Thanks for your response! |
There was a problem hiding this comment.
can you extend https://github.com/asyncapi/asyncapi-react/blob/master/library/src/__tests__/docs/v3/streetlights-mqtt.json instead of creating a new test document?
|
@derberg done |
There was a problem hiding this comment.
sorry, I meant like edit the existing YAML file and add additional configuration that you can use in test.
we always try to make sure that whatever new case we support and test, is the easily "quick to see" in https://asyncapi.github.io/asyncapi-react/
…th only password flow
|
No worries. Initially I thought you may want to keep your test file clean of new use cases because in security schemes you have "supportedOauthFlows" and now "oauth2Password" which may look strange. The thing is that the bug is happening if we have OAuth with only password flow so we have to add separate scheme. Anyway, the json is updated and I had to delete my test as well since adding the test data in the same file made it duplicate with "and streetlight mqtt example" test. |
|
Thanks for the PR! /rtm |
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fix for rendering specifications that contain oauth2 password flow only.
Related issue(s)
Resolves #1007