Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework sequencer logic around CheckTx and transaction execution #1958

Open
Fraser999 opened this issue Feb 10, 2025 · 0 comments
Open

Rework sequencer logic around CheckTx and transaction execution #1958

Fraser999 opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
bug Something isn't working mempool sequencer pertaining to the astria-sequencer crate

Comments

@Fraser999
Copy link
Contributor

We currently are too permissive in our CheckTx flow, allowing txs into the CometBFT and appside mempools which will subsequently fail execution via stateful checks in the check_and_execute flow.

This is problematic as such txs are not recorded in the sequencer block nor in the CometBFT txs. This means they remain present in the mempools of all but the validator proposing the block for that round.

We need to rework this so that such txs either fail during CheckTx (meaning they never enter mempools), or that execution failures are recorded rather than being skipped, meaning all sequencers (validators and full nodes) are able to remove such failed txs from their mempools. Potentially a combination of both approaches will prove to be the best solution.

@Fraser999 Fraser999 self-assigned this Feb 10, 2025
@Fraser999 Fraser999 added bug Something isn't working sequencer pertaining to the astria-sequencer crate mempool labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mempool sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

No branches or pull requests

1 participant