Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oct612x: Build failure due to EXTRA_CFLAGS being removed in the kernel #76

Open
InterLinked1 opened this issue Feb 22, 2025 · 0 comments · May be fixed by #77
Open

oct612x: Build failure due to EXTRA_CFLAGS being removed in the kernel #76

InterLinked1 opened this issue Feb 22, 2025 · 0 comments · May be fixed by #77

Comments

@InterLinked1
Copy link
Contributor

Support for EXTRA_CFLAGS has been removed in the kernel, rendering the Kbuild and Makefile for the oct612x library invalid. This now manifests as a build failure due to the missing options:

  CC [M]  oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.o
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.c:34:10: fatal error: octdef.h: No such file or directory
   34 | #include "octdef.h"
      |          ^~~~~~~~~~
compilation terminated.
make[5]: *** [/usr/src/linux-next/scripts/Makefile.build:203: oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.o] Error 1
make[4]: *** [/usr/src/linux-next/scripts/Makefile.build:461: oct612x] Error 2
InterLinked1 added a commit to InterLinked1/dahdi-linux that referenced this issue Feb 22, 2025
@InterLinked1
oct612x: Use ccflags-y instead of EXTRA_CFLAGS.
cc2a0dc 
ccflags-y was added to the kernel back in 2007, in commit
f77bf01425b11947eeb3b5b54. Recent kernel commit
dbd83ea09699390892e5efecddd74ae43a00f071 has now completely
removed the deprecated EXTRA_CFLAGS.

Comments in Kbuild and the Makefile for the oct612x library were
added back when it was created in 2013 in commit f65299e
to use the newer ccflags-y based on the kernel version,
but the change was never made to conditionally move away
from the EXTRA_CFLAGS.

Now that the older way no longer exists, always use ccflags-y.

Resolves: asterisk#76
@InterLinked1 InterLinked1 linked a pull request Feb 22, 2025 that will close this issue
Open
InterLinked1 added a commit to InterLinked1/dahdi-linux that referenced this issue Feb 22, 2025
@InterLinked1
Kbuild: Use ccflags-y instead of EXTRA_CFLAGS.
ec88adb 
ccflags-y was added to the kernel back in 2007, in commit
f77bf01425b11947eeb3b5b54. Recent kernel commit
dbd83ea09699390892e5efecddd74ae43a00f071 has now completely
removed the deprecated EXTRA_CFLAGS.

Comments in Kbuild and the Makefile for the oct612x library were
added back when it was created in 2013 in commit f65299e
to use the newer ccflags-y based on the kernel version,
but the change was never made to conditionally move away
from the EXTRA_CFLAGS.

Now that the older way no longer exists, always use ccflags-y.

Resolves: asterisk#76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oct612x: Use ccflags-y instead of EXTRA_CFLAGS. InterLinked1/dahdi-linux
1 participant
@InterLinked1