-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIB004 The manifest file contains syntax errors #111
Comments
removing the files property and array avoids the error |
@justcla, please investigate why we're reporting a syntax error in seemingly valid JSON. |
I tested this on the latest build from master. I put the same json into a libman.json file in a new ASP.NET (Framework) MVC app that had a "node_modules/jquery/dist" dir with the two jquery files listed and it ran perfectly. ` { "version": "1.0", "defaultProvider": "filesystem", "libraries": [ { "library": "node_modules/jquery/dist/", "destination": "Scripts/lib/jquery", "files": [ "jquery.min.js", "jquery.min.map" ] } ] } ` |
Unable to reproduce with the latest code. |
Same issue for me as well, removing the files block also stopped the error. If on a new ASP.NET Core 2.1 project in VS, using Add Client-Side Library creates a libman.json file that will not pass syntax checking, to test add "twitter-bootstrap" package. Reproduced error on two machines. |
Still broken on Version 15.8.0 Preview 5.0 |
I'm having this same issue in Visual Studio 15.8.5 in an ASP.NET Core 2.1 application. Has anyone found a solution for this? |
I haven't been able to repro this on my box (15.9). I've tried using the libman.json contents that @sysdev-cof posted in the original issue with a Web Application project, and also similar to the latest post in a .NET Core 2.1 app. Can you guys think of anything that I might be missing from the repro? |
Thanks for looking at this again... Repro steps for me just now: Visual Studio 15.9 Preview 3 Click Install Result: |
Yes, thanks for looking at this again. I just tried with a new install of Windows 10 and Visual Studio 15.8.7. I chose an empty ASP.NET Core 2.1 project and tried to add a specific jquery file from cdnjs. Here's my libman.json file. {
"version": "1.0",
"defaultProvider": "cdnjs",
"libraries": [
{
"library": "[email protected]",
"destination": "wwwroot/jquery/",
"files": [
"jquery.js"
]
}
]
} Restore operation started... |
This is fixed for me in today's 15.9.0 Preview 4.0 |
This still happens for me with NuGet package Microsoft.Web.LibraryManager.Build version 1.0.163 in Visual Studio Professional 2017 version 15.9.3. Removing the files properties and arrays of all libraries works, but I don't think this is how it's supposed to work. |
I'm just getting back to trying this again and it's fixed for me in Version 15.9.4. |
I spoke too soon. It seems that library restore is only partially working now. If I specify the jquery files that I want like this.
Then when I right-click on libman.json and choose Restore Client-Side Libraries, the restore works. But I have enabled Restore Client-Side Libraries on Build and when I build, I'm still seeing the error below. LIB004 Library Manager manifest contains syntax errors. Please fix the errors in libman.json, then try again. |
when you enable "Restore Client-Side Libraries on Build" This error can be seen. It's in latest VS Release too 15.9.4. Should be something to do with Microsoft.Web.LibraryManager.Build Nuget When files are mention the build nuget show's that error. |
@justcla are we investigating this ? Since i'm unable to restore with "Build" package i am suppose to tell every dev to restore manually. Restore fails most of the time with "CDNJS" when some files return 404 , there so we need to mention the required files in order for this to work. Can i say to restore other files if there are 404 ? eg : https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.6/umd/popper.js.map (404) CLI tool works with "Files" i can integrate that to CICD. |
I'm still unable to reproduce this at all on either VS15.9.6 and VS16 previews. I've tried using the build package to restore as well as saving the file in VS. Both work just fine for me. If someone can still repro this, can you specify which version of the Microsoft.Web.LibraryManager.Build package you're using? Or ideally share a project that can reproduce the problem? |
I am still facing this issue with VS 15.9.10 in eShopOnContainers project |
This resolved the error for me in VS2022 Version 17.3.5 and Microsoft.Web.LibraryManager.Build 2.1.175 If I add a new library via the UI and select the files option the error occurs from the json it creates. |
Functional impact
LibMan with VS 15.8.0 Preview 2.0 has stopped working for me, parsing issue with filesystem providers' "files" array.
Minimal repro steps
{
"version": "1.0",
"defaultProvider": "filesystem",
"libraries": [
{
"library": "node_modules/jquery/dist/",
"destination": "Scripts/lib/jquery",
"files": [ "jquery.min.js", "jquery.min.map" ]
}
]
}
Saving this results in:
LIB004 The manifest file contains syntax errors in the Error List pad
Expected result
This used to work last week ??
Actual result
LIB004 The manifest file contains syntax errors in the Error List pad
Further technical details
??
The text was updated successfully, but these errors were encountered: