You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The plugin template is violating the asdf project's "golden rules" for portability
Most specifically it's using echo and source liberally, and these have been considered "banned commands" for more than a year. (I understand these are bash scripts and can make assumptions but... still!)
Steps to reproduce
read the source, or generate the template
Expected behavior
No golden rule violations. In fact I'd expect the template to be enforcing this as part of linting?
Describe the bug
The plugin template is violating the asdf project's "golden rules" for portability
Most specifically it's using
echo
andsource
liberally, and these have been considered "banned commands" for more than a year. (I understand these are bash scripts and can make assumptions but... still!)Steps to reproduce
read the source, or generate the template
Expected behavior
No golden rule violations. In fact I'd expect the template to be enforcing this as part of linting?
Screenshots
Additional context
https://github.com/asdf-vm/asdf/blame/fce6c534daf6c0b2eed7dc633b18f7b87f665d2f/test/banned_commands.bats#L5-L24
The text was updated successfully, but these errors were encountered: