Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin actions to a full length commit SHA ? #57

Open
marcwrobel opened this issue Sep 8, 2022 · 2 comments
Open

Pin actions to a full length commit SHA ? #57

marcwrobel opened this issue Sep 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@marcwrobel
Copy link
Contributor

In its documentation, https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions, GitHub recommends to pin GitHub actions to a full length commit SHA.

The Disadvantage of this is that it's more work compared to pinning actions to a tag. But it can be simplified by letting Dependabot handle the dependency upgrades.

One nice side effect is that there will be more activity to the repository. So this helps preventing scheduled GitHub Actions from becoming disabled when there is no activity for X consecutive days. Note that this is less needed by plugins in adsf-community because it seems there is a bot that generates activity every now and then (see "Update .github/CODEOWNERS" commits in https://github.com/asdf-community/asdf-graalvm/commits/master for exemple).

Should GitHub action pinning to a full length commit SHA be applied to this template repository ?

@marcwrobel marcwrobel added the enhancement New feature or request label Sep 8, 2022
@marcwrobel
Copy link
Contributor Author

marcwrobel commented Sep 8, 2022

As an example, GitHub action pinning to a full length commit SHA has been applied on asdf-quarkus

@jthegedus
Copy link
Collaborator

Should GitHub action pinning to a full length commit SHA be applied to this template repository?

Probably. I am in the progress of re-working this repo to make it easier for people to use on GitHub. I will add this feature to that rework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants