Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static font subfamilies include base font name for more than the four RIBBI fonts #138

Open
arrowtype opened this issue May 30, 2024 · 0 comments
Assignees

Comments

@arrowtype
Copy link
Owner

arrowtype commented May 30, 2024

NameID 1 should only be the same for Regular, Italic, Bold, and Bold Italic. Other weights should put their weight name into NameID 1.

The designspace sources/shantell_sans-ital_wght_BNCE_INFM_SPAC--static-simplified.designspace needs to be adjusted to enable better style linking, and then the static fonts should be rebuilt. This may or may not require a re-run of the build prep, but I’ll look into that.

Relevant fontbakery check:

▶ fontbakery check-adobefonts "fonts/Shantell Sans/Desktop/Static/OTF/*.*tf"
Start ... running 3439 individual check executions.
 >> com.adobe.fonts/check/family/max_4_fonts_per_family_name
    Verify that each group of fonts with the same nameID 1 has maximum of 4 fonts.
    

    Rationale:                                                                
                                                                                                                                                                                      
    Per the OpenType spec:                                                                                                                                                            
                                                                                                                                                                                      
    'The Font Family name [...] should be shared among at most four fonts that differ only in weight or style [...]'                                                                  
                                                                                                                                                                                      
    More info: https://github.com/fonttools/fontbakery/pull/2372

    FAIL Family 'Shantell Sans Informal' has 12 fonts (should be 4 or fewer). [code: too-many]                                                                                        
    FAIL Family 'Shantell Sans Bouncy' has 12 fonts (should be 4 or fewer). [code: too-many]                                                                                          
    FAIL Family 'Shantell Sans Normal' has 12 fonts (should be 4 or fewer). [code: too-many]                                                                                          
    FAIL Family 'Shantell Sans Informal Bouncy' has 12 fonts (should be 4 or fewer). [code: too-many]                                                                                 

    Result: FAIL

Will work on this ASAP, and make a new release.

@arrowtype arrowtype self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant