Skip to content

Add an "all" granularity to humanize #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MarkKoz opened this issue Aug 7, 2021 · 4 comments · May be fixed by #1018
Open

Add an "all" granularity to humanize #1014

MarkKoz opened this issue Aug 7, 2021 · 4 comments · May be fixed by #1018
Labels
enhancement

Comments

@MarkKoz
Copy link

MarkKoz commented Aug 7, 2021

Feature Request

Once #997 is implemented, using full precision would become more viable. However, it's currently cumbersome to specify that; it requires a list of all units. Sure, a wrapper can be made to abstract that away, but it'd be convenient to just pass the string "all".
@krisfremen
Copy link
Member

I concur, this is a good idea.

@jadchaar @anishnya @systemcatch what is your opinion?

@MarkKoz would you like to give it a go and do a PR?

@anishnya
Copy link
Member

anishnya commented Aug 7, 2021

I concur, this is a good idea.

@jadchaar @anishnya @systemcatch what is your opinion?

@MarkKoz would you like to give it a go and do a PR?

I agree this is a good idea.

@MarkKoz
Copy link
Author

MarkKoz commented Aug 7, 2021

@MarkKoz would you like to give it a go and do a PR?

Sure.

MarkKoz added a commit to MarkKoz/arrow that referenced this issue Aug 8, 2021
@MarkKoz
Add an "all" granularity to humanize
89f77b1 
It's more convenient to pass a simple short string than to pass a list
of 7 strings.

Resolve arrow-py#1014
@MarkKoz MarkKoz linked a pull request Aug 8, 2021 that will close this issue
Open
5 tasks
@systemcatch
Copy link
Collaborator

Chiming in late but I think this is a really good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an "all" granularity to humanize MarkKoz/arrow
4 participants
@krisfremen @MarkKoz @systemcatch @anishnya