Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ns to have run-time defined namespaces #337

Open
4 tasks
ValarDragon opened this issue Jan 5, 2021 · 1 comment
Open
4 tasks

Allow ns to have run-time defined namespaces #337

ValarDragon opened this issue Jan 5, 2021 · 1 comment

Comments

@ValarDragon
Copy link
Member

Summary

Namespace names at the moment must be &'static str. There are use cases in which you would want runtime defined namespaces, e.g. for generating many circuits of different sizes, or prefixing what step of a computation you are in.

I think we should try to generalize this to &str. I'm not really clear why its limited to &'static str at the moment, is this imposed by tokio-rs/tracing's info_span! macro?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Pratyush
Copy link
Member

Pratyush commented Jan 5, 2021

Yes, the limitation is due to tracing. There might be a way to work around it though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants