Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConstraintSynthesizer::generate_constraints not consume self by value #323

Open
Pratyush opened this issue Oct 26, 2020 · 5 comments · May be fixed by #348
Open

Make ConstraintSynthesizer::generate_constraints not consume self by value #323

Pratyush opened this issue Oct 26, 2020 · 5 comments · May be fixed by #348
Labels
D-easy Difficulty: easy

Comments

@Pratyush
Copy link
Member

No description provided.

@weikengchen
Copy link
Member

Does it mean that we just change self to &self?

My first attempt shows that this seems good: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0dcc9126df1c78347ad34fc5238617a4

@Pratyush
Copy link
Member Author

yeah, it's mostly just an issue with updating everything downstream =)

@Pratyush Pratyush changed the title Make ConstraintSynthesizer::generate_constraints not consume self Make ConstraintSynthesizer::generate_constraints not consume self by value Oct 26, 2020
@Pratyush Pratyush transferred this issue from another repository Nov 19, 2020
@Pratyush Pratyush transferred this issue from arkworks-rs/template Nov 20, 2020
@Pratyush Pratyush added D-easy Difficulty: easy help wanted labels Nov 20, 2020
@Pratyush
Copy link
Member Author

@weikengchen Now that cloning ConstraintSystemRef is cheap, is this still an issue?

@weikengchen
Copy link
Member

Nope? Because the one that may need cloning is ConstraintSynthesizer rather than ConstraintSystemRef.

@Pratyush
Copy link
Member Author

Oh oops, misread the title lol. Ok, will address this in my current set of changes.

@Pratyush Pratyush linked a pull request Apr 20, 2021 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-easy Difficulty: easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Relation trait arkworks-rs/snark
2 participants
@Pratyush @weikengchen