-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examine more carefully on the bound for UInt addmany
implementation
#23
Labels
D-easy
Difficulty: easy
Comments
Hmm so it should |
or |
why the |
Pratyush
pushed a commit
that referenced
this issue
Aug 8, 2021
tgodden
pushed a commit
to tgodden/r1cs-std
that referenced
this issue
Nov 29, 2022
Pratyush
added a commit
that referenced
this issue
Jan 20, 2023
Co-authored-by: Tom Godden <[email protected]> Co-authored-by: mmagician <[email protected]> Co-authored-by: Pratyush Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current implementation of
addmany
has a number of bounds:https://github.com/arkworks-rs/r1cs-std/blob/master/src/bits/uint.rs#L184
However, these bounds seem to be too strict. This part of the code is supposed for additions. And the bounds here seem for multiplication.
The text was updated successfully, but these errors were encountered: