ec: small refactor on pairing (#899)

Author: tcoratger

curves/curve-constraint-tests/src/lib.rs

@@ -21,7 +21,7 @@ pub mod fields {
             AllocationMode::Constant,
         ];
         for &mode in &modes {
-            let cs = ConstraintSystem::<ConstraintF>::new_ref();
+            let cs = ConstraintSystem::new_ref();
 
             let mut rng = test_rng();
             let a_native = F::rand(&mut rng);
@@ -152,10 +152,7 @@ pub mod fields {
             for c in &mut constants {
                 *c = UniformRand::rand(&mut test_rng());
             }
-            let bits = [
-                Boolean::<ConstraintF>::constant(false),
-                Boolean::constant(true),
-            ];
+            let bits = [Boolean::constant(false), Boolean::constant(true)];
             let lookup_result = AF::two_bit_lookup(&bits, constants.as_ref())?;
             assert_eq!(lookup_result.value()?, constants[2]);
             assert!(cs.is_satisfied().unwrap());

ec/src/pairing.rs

@@ -333,12 +333,10 @@ impl<P: Pairing> Mul<P::ScalarField> for MillerLoopOutput<P> {
 
 /// Preprocesses a G1 element for use in a pairing.
 pub fn prepare_g1<E: Pairing>(g: impl Into<E::G1Affine>) -> E::G1Prepared {
-    let g: E::G1Affine = g.into();
-    E::G1Prepared::from(g)
+    E::G1Prepared::from(g.into())
 }
 
 /// Preprocesses a G2 element for use in a pairing.
 pub fn prepare_g2<E: Pairing>(g: impl Into<E::G2Affine>) -> E::G2Prepared {
-    let g: E::G2Affine = g.into();
-    E::G2Prepared::from(g)
+    E::G2Prepared::from(g.into())
 }