Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arizona.js: allow subscribe to "Subscribe to global events." #110

Open
paulo-ferraz-oliveira opened this issue Jun 29, 2024 · 4 comments
Open
Assignees

Comments

@paulo-ferraz-oliveira
Copy link
Member

No description provided.

@paulo-ferraz-oliveira
Copy link
Member Author

I'm gonna take this as a starting point to look at the JavaScript interface. It's possible I break a couple of things as we discussed already.

@paulo-ferraz-oliveira
Copy link
Member Author

paulo-ferraz-oliveira commented Jul 14, 2024

Also

arizona.subscribe("reload", () => {
  location.reload();
});

should probably be internal to arizona.js so we get rid of an extra .js 😄

(or maybe I can't, so easily, looking at the code, but I'm sure there's a way to pass options to not have this file isolated - it seems to be there only to make a choice on the Erlang side of things)

@williamthome
Copy link
Member

Also

arizona.subscribe("reload", () => {
  location.reload();
});

should probably be internal to arizona.js so we get rid of an extra .js 😄

This piece of code is from arizona-live-reload.js, so it's a development thing. It should be optional. We have not defined/discussed an interface for the live-reload, and this file may grow (or not). I don't see it as a problem right now. We could change this later.

@paulo-ferraz-oliveira
Copy link
Member Author

Yeah, I saw it being called separately in the code, so I won't touch it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants