Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Adding support to disable make_before_break for PIM sparse-mode #4745

Merged
merged 15 commits into from
Nov 26, 2024
Merged

Feat(eos_cli_config_gen): Adding support to disable make_before_break for PIM sparse-mode #4745

merged 15 commits into from
Nov 26, 2024

Conversation

davidhayes9
Copy link

Change Summary

Adding support to disable make_before_break for PIM sparse-mode

Related Issue(s)

Fixes #4743

Component(s) name

arista.avd. eos_cli_config_gen

Proposed changes

Added support to disable make_before_break for PIM sparse-mode in default and non-default VRF

    router_pim_sparse_mode:
      ipv4:
        # Enable/Disable Make-Before-Break.
        make_before_break: <bool>
      vrfs:
        - name: foo
          ipv4:
            # Enable/Disable Make-Before-Break.
            make_before_break: <bool>

How to test

Tested on molecule with keys added in both default and non-VRF

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@davidhayes9 davidhayes9 requested review from a team as code owners November 19, 2024 11:29
@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4745
# Activate the virtual environment
source test-avd-pr-4745/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/davidhayes9/avd.git@issue4743#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/davidhayes9/avd.git#/ansible_collections/arista/avd/,issue4743 --force
# Optional: Install AVD examples
cd test-avd-pr-4745
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 19, 2024
@davidhayes9 davidhayes9 changed the title Adding support to disable make_before_break for PIM sparse-mode Feat (eos_cli_config_gen): Adding support to disable make_before_break for PIM sparse-mode Nov 19, 2024
@MaheshGSLAB MaheshGSLAB changed the title Feat (eos_cli_config_gen): Adding support to disable make_before_break for PIM sparse-mode Feat(eos_cli_config_gen): Adding support to disable make_before_break for PIM sparse-mode Nov 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc dismissed Shivani-gslab’s stale review November 22, 2024 10:36

Comments addressed

gmuloc
gmuloc previously approved these changes Nov 22, 2024
View reviewed changes
laxmikantchintakindi
laxmikantchintakindi requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a make-before-break: true in router_pim_sparse_mode.ipv4 can be added in host2 to improve document coverage.

@gmuloc gmuloc dismissed their stale review November 22, 2024 11:59

I have made changes

gmuloc
gmuloc previously requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClausHolbechArista I have made changes so want another maintainer to take a look

@ClausHolbechArista ClausHolbechArista dismissed gmuloc’s stale review November 22, 2024 13:58

block no longer needed

@gmuloc gmuloc merged commit 766dd59 into aristanetworks:devel Nov 26, 2024
45 checks passed
ClausHolbechArista pushed a commit to ClausHolbechArista/avd that referenced this pull request Nov 27, 2024
@davidhayes9 @ClausHolbechArista
Feat(eos_cli_config_gen): Adding support to disable make_before_break…
6d17730 
… for PIM sparse-mode (aristanetworks#4745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@laxmikantchintakindi laxmikantchintakindi laxmikantchintakindi approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@Shivani-gslab Shivani-gslab Shivani-gslab left review comments

@gmuloc gmuloc gmuloc left review comments

Assignees

@davidhayes9 davidhayes9

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat (eos_cli_config_gen): Add support to disable make-before-break under router pim sparse-mode
6 participants
@davidhayes9 @gmuloc @ClausHolbechArista @MaheshGSLAB @Shivani-gslab @laxmikantchintakindi