Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide metrics of GitHub API rate limit #21877

Open
int128 opened this issue Feb 14, 2025 · 0 comments
Open

Provide metrics of GitHub API rate limit #21877

int128 opened this issue Feb 14, 2025 · 0 comments
Labels
component:application-sets Bulk application management related component:metrics enhancement New feature or request

Comments

@int128
Copy link

int128 commented Feb 14, 2025

Summary

It would be nice if the ApplicationSet controller provides the metrics of GitHub API rate limit.

Motivation

When the pull request generator or SCM generator is used, it may cause exceeding the rate limit of GitHub API token.

Proposal

ApplicationSet controller provides the metrics like argocd_appset_github_ratelimit_remaining.
@int128 int128 added the enhancement New feature or request label Feb 14, 2025
@reggie-k reggie-k added component:application-sets Bulk application management related bug Something isn't working component:metrics and removed bug Something isn't working labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:application-sets Bulk application management related component:metrics enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@int128 @reggie-k