Standardize the application-related log structured fields

[andrii-korotkov-verkada]

Summary

In some places like application controller file there's a standardization to specify application structured field value without a namespace, while also adding namespace as a separate field + a couple more fields

argo-cd/controller/appcontroller.go

Lines 101 to 108 in 5d0a3e6

	func getAppLog(app *appv1.Application) *log.Entry {
	return log.WithFields(log.Fields{
	"application": app.Name,
	"app-namespace": app.Namespace,
	"app-qualified-name": app.QualifiedName(),
	"project": app.Spec.Project,
	})
	}

. However, it's not like that in all files, and some files still log the application field with prepended namespace and /. It'd be great to standardize this across the codebase.

Motivation

Easier and more consistent log analysis experience.

Proposal

Audit places which log or should application field, move the helper function to the common utils and use it in those places.

[d-cryptic]

Hi, I want to contribute on this issue. Can you assign this to me please?