refactor: rename mu field to the mutex field

Signed-off-by: Philipp Plotnikov <[email protected]>
argoproj-labs · Jan 30, 2024 · 613a7c7 · 613a7c7
1 parent 6f70f8a
commit 613a7c7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/pkg/plugin/httproute.go b/pkg/plugin/httproute.go
@@ -14,7 +14,7 @@ import (
 
 var (
 	httpHeaderRoute = HTTPHeaderRoute{
-		mu:              sync.Mutex{},
+		mutex:           sync.Mutex{},
 		managedRouteMap: make(map[string]int),
 		rule: v1beta1.HTTPRouteRule{
 			Matches:     []v1beta1.HTTPRouteMatch{},

diff --git a/pkg/plugin/plugin.go b/pkg/plugin/plugin.go
@@ -31,7 +31,6 @@ func (r *RpcPlugin) InitPlugin() pluginTypes.RpcError {
 		}
 	}
 	r.Client = clientset
-
 	return pluginTypes.RpcError{}
 }
 
@@ -76,13 +75,13 @@ func (r *RpcPlugin) SetHeaderRoute(rollout *v1alpha1.Rollout, headerRouting *v1a
 	}
 	switch {
 	case gatewayAPIConfig.HTTPRoute != "":
-		httpHeaderRoute.mu.Lock()
+		httpHeaderRoute.mutex.Lock()
 		rpcError := r.setHTTPHeaderRoute(rollout, headerRouting, &gatewayAPIConfig)
 		if rpcError.HasError() {
-			httpHeaderRoute.mu.Unlock()
+			httpHeaderRoute.mutex.Unlock()
 			return rpcError
 		}
-		httpHeaderRoute.mu.Unlock()
+		httpHeaderRoute.mutex.Unlock()
 	default:
 		return pluginTypes.RpcError{
 			ErrorString: HTTPRouteFieldIsEmptyError,
@@ -109,13 +108,13 @@ func (r *RpcPlugin) RemoveManagedRoutes(rollout *v1alpha1.Rollout) pluginTypes.R
 	}
 	switch {
 	case gatewayAPIConfig.HTTPRoute != "":
-		httpHeaderRoute.mu.Lock()
+		httpHeaderRoute.mutex.Lock()
 		rpcError := r.removeHTTPManagedRoutes(rollout.Spec.Strategy.Canary.TrafficRouting.ManagedRoutes, &gatewayAPIConfig)
 		if rpcError.HasError() {
-			httpHeaderRoute.mu.Unlock()
+			httpHeaderRoute.mutex.Unlock()
 			return rpcError
 		}
-		httpHeaderRoute.mu.Unlock()
+		httpHeaderRoute.mutex.Unlock()
 	default:
 		return pluginTypes.RpcError{
 			ErrorString: HTTPRouteFieldIsEmptyError,

diff --git a/pkg/plugin/types.go b/pkg/plugin/types.go
@@ -33,7 +33,7 @@ type GatewayAPITrafficRouting struct {
 }
 
 type HTTPHeaderRoute struct {
-	mu              sync.Mutex
+	mutex           sync.Mutex
 	managedRouteMap map[string]int
 	rule            v1beta1.HTTPRouteRule
 }