Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update doc to reflect password secret behaviour #1601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this?

/kind documentation

What does this PR do / why we need it:
This PR updates documentation for using argocd-cluster and argocd-secret secrets behavior.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #1483

How to test changes / Special notes to the reviewer:

@anandrkskd
Copy link
Contributor Author

hey @svghadi, can you review this PR

@svghadi svghadi changed the title update doc to reflect password secret behaviour docs: update doc to reflect password secret behaviour Nov 28, 2024
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, rest all looks good. Thanks.

The operator will watch for changes to the `admin.password` value. When a change is made the password is synchronized to
Argo CD automatically.
NOTE: The operator strictly uses this secret for setting the initial password for the admin user, making any change to this secret doesn't effect or update the password for the admin user.
To update password use [argocd-cli](https://argo-cd.readthedocs.io/en/stable/user-guide/commands/argocd_account_update-password/) or [upstream-documentation](https://argo-cd.readthedocs.io/en/release-2.2/faq/#i-forgot-the-admin-password-how-do-i-reset-it).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To update password use [argocd-cli](https://argo-cd.readthedocs.io/en/stable/user-guide/commands/argocd_account_update-password/) or [upstream-documentation](https://argo-cd.readthedocs.io/en/release-2.2/faq/#i-forgot-the-admin-password-how-do-i-reset-it).
To update password use [argocd-cli](https://argo-cd.readthedocs.io/en/stable/user-guide/commands/argocd_account_update-password/) or [upstream-documentation](https://argo-cd.readthedocs.io/en/stable/faq/#i-forgot-the-admin-password-how-do-i-reset-it).

Can we point to stable doc instead of a 2.2 version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin password not changed after modifying the ...-cluster secret
2 participants