Skip to content

Expose serial number for App-Lab in network mode #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose serial number for App-Lab in network mode #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pkg/board/board.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,9 @@ func FromFQBN(ctx context.Context, fqbn string) ([]Board, error) {
if len(port.GetMatchingBoards()) > 0 {
boardName = port.GetMatchingBoards()[0].GetName()
}

serial := strings.ToLower(port.GetPort().GetHardwareId()) // in windows this is uppercase.
switch port.GetPort().GetProtocol() {
case SerialProtocol:
serial := strings.ToLower(port.GetPort().GetHardwareId()) // in windows this is uppercase.

// TODO: we should store the board custom name in the product id so we can get it from the discovery service.
var customName string
if conn, err := adb.FromSerial(serial, ""); err == nil {
Expand Down Expand Up @@ -215,6 +213,7 @@ func FromFQBN(ctx context.Context, fqbn string) ([]Board, error) {
boards = append(boards, Board{
Protocol: NetworkProtocol,
Address: port.GetPort().GetAddress(),
Serial: serial,
Copy link
Contributor

@lucarin91 lucarin91 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In network mode you need to get it like the hostname

port.GetPort().GetProperties()["serial_number"];

BoardName: boardName,
CustomName: customName,
})
Expand Down