Expose serial number for App-Lab in network mode #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lucarin91 How can I test it? |
Contributor
Probably the best solution is just to write a test or an example that uses that library |
lucarin91
requested changes
Nov 11, 2025
| boards = append(boards, Board{ | ||
| Protocol: NetworkProtocol, | ||
| Address: port.GetPort().GetAddress(), | ||
| Serial: serial, |
Contributor
There was a problem hiding this comment.
In network mode you need to get it like the hostname
port.GetPort().GetProperties()["serial_number"];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A board connected via both USB and Network currently shows up as two separate devices in the board list. This makes it difficult for a client application to know it is the same physical board.
We need a way to "deduplicate" these entries by providing a common identifier, allowing the client to show just one entry for that board.
Change description
Additional Notes
Reviewer checklist
main.