Skip to content

Deployed platform.txt in v1.8.7 is not the good one #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
landret opened this issue Nov 21, 2022 · 3 comments
Closed

Deployed platform.txt in v1.8.7 is not the good one #123

landret opened this issue Nov 21, 2022 · 3 comments

Comments

@landret
Copy link
Contributor

landret commented Nov 21, 2022

Hi,
when downloading megaavr package v1.8.7 from the Arduino IDE, the platform.txt included is incorrect. It is not the same as on Github. It is missing #101 PR commit that was merged on 26 september 2021.

@per1234
Copy link
Contributor

per1234 commented Nov 21, 2022

Hi @landret. I think the way you have formulated this report is likely to cause confusion.

Your report implies it is unexpected that the platform.txt or the 1.8.7 release does not contain the change from #101. #101 was created 4 months after the time of the 1.8.7 release, so it is expected that the 1.8.7 release would not contain that change:

1.8.7...master

So it seems that what you actually intended was to request a new release be created.

@landret
Copy link
Contributor Author

landret commented Nov 21, 2022

Hi @per1234
I thought v1.8.7 was released after change from #101. I misunderstood, sorry about that.

Indeed, it would be interesting to have a new release created as the last one happened nearly 2 years ago.

@facchinm
Copy link
Member

Core 1.8.8 contains #101 , closing as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants