Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACs payment status support #7

Open
judgej opened this issue Feb 14, 2018 · 4 comments
Open

BACs payment status support #7

judgej opened this issue Feb 14, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@judgej
Copy link
Contributor

judgej commented Feb 14, 2018

Along with the fasterPaymentStatus objects returned for the payment account address, there is now a bacsStatus object with similar statuses.

A new PUT method allows the BACs statuses (diectCredit and diectDebit) to be enabled and disabled.

@judgej judgej added the enhancement New feature or request label Feb 14, 2018
@judgej judgej self-assigned this Feb 14, 2018
@judgej
Copy link
Contributor Author

judgej commented Feb 14, 2018

There are also half a dozen new BACs webhooks, and four new BACS endpoints (two GET and two PUT).

@bradydan
Copy link

Are these all new additions to the Starling payments API?

We don’t need to do anything with BACS

@judgej
Copy link
Contributor Author

judgej commented Feb 15, 2018

Yes, these are all new. I'm trying to keep up with any changes to the API, so we don't get any surprises.

It is something to be aware of. We may, for example, miss some incoming funding payments if we are not watching the BACS webhooks.

@bradydan
Copy link

We can’t accommodate changes at this stage. Otherwise it’s an ever-moving target. Make a note of the webhook/API changes but there should be no coding changes at this stage.

judgej added a commit that referenced this issue Mar 1, 2018
…e and retrieval.

Not tested yet.
Four new endpoints to set up and manage BACS mandates.
Some refactor of common properties into traits will help simplfy
code a lot, in partciaular the accountUid and addressUid proeprties.
judgej added a commit that referenced this issue Mar 1, 2018
The webhooks have not been created yet.
judgej added a commit that referenced this issue Mar 1, 2018
Will come back to this later, with testing, objects, models.
judgej added a commit that referenced this issue Apr 27, 2018
No tests for these yet, and not yet tried against sandbox.
judgej added a commit that referenced this issue Apr 27, 2018
judgej added a commit that referenced this issue Apr 27, 2018
not yet tested or tried against sandbox.
judgej added a commit that referenced this issue Apr 27, 2018
Still not tested, but that will come.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants