Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More request validations #6

Open
7 of 8 tasks
judgej opened this issue Feb 3, 2018 · 1 comment
Open
7 of 8 tasks

More request validations #6

judgej opened this issue Feb 3, 2018 · 1 comment
Assignees
@judgej

Comments

@judgej
Copy link
Contributor

judgej commented Feb 3, 2018 •
edited
Loading

We need to make sure we can catch all data validation errors before it reaches the bank API, just for robustness and to keep the remote bank API logs cleaner. This list would be good:

  • UUIDs - lower-case UUID4 seems to be the convention here
  • Mandatory/optional fields
  • Numeric/integer
  • String min/max length
  • Regular expression, with some common ones:
    • Reference
    • Payee name
    • Account description
@judgej judgej self-assigned this Feb 3, 2018
@judgej judgej changed the title More request validartions More request validations Feb 4, 2018
judgej added a commit that referenced this issue Feb 4, 2018
@judgej
Issue #6 A lot more validation rules added and used.
8415cc5
@judgej
Copy link
Contributor Author

judgej commented Feb 4, 2018

The setting of accountUid, addressUid and paymentUid can be moved to the AbstractRequest to remove a fair number of duplications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judgej judgej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judgej