fix: lots of CodeChecker warnings

Mostly double-float casts, functions without arguments without an
explicit `void` in the parameter list, but in platformchannel.c there
were actually some memory leaks on error paths, which are now fixed.

Also enable -pedantic for even more diagnostics.

Author: ardera

CMakeLists.txt

@@ -162,13 +162,14 @@ target_link_libraries(flutterpi_module PUBLIC
 )
 
 target_include_directories(flutterpi_module PUBLIC
-  ${CMAKE_SOURCE_DIR}/third_party/flutter_embedder_header/include
   ${CMAKE_SOURCE_DIR}/src
   ${CMAKE_BINARY_DIR}
+  ${CMAKE_SOURCE_DIR}/third_party/mesa3d/include
+  ${CMAKE_SOURCE_DIR}/third_party/flutter_embedder_header/include
 )
 
 target_compile_options(flutterpi_module PUBLIC
-  $<$<CONFIG:Debug>:-O0 -Wall -Wextra -Wno-sign-compare -Werror -ggdb -U_FORTIFY_SOURCE -DDEBUG>
+  $<$<CONFIG:Debug>:-O0 -Wall -Wextra -Wno-sign-compare -Wswitch-enum -Wformat -Wdouble-promotion -Wno-overlength-strings -Wno-gnu-zero-variadic-macro-arguments -pedantic -Werror -ggdb -U_FORTIFY_SOURCE -DDEBUG>
   $<$<CONFIG:RelWithDebInfo>:-O3 -Wall -Wextra -Wno-sign-compare -ggdb -DNDEBUG>
   $<$<CONFIG:Release>:-O3 -Wall -Wextra -Wno-sign-compare -DNDEBUG>
 )
@@ -237,6 +238,7 @@ if (ENABLE_VULKAN)
     target_sources(flutterpi_module PRIVATE
       src/vk_gbm_render_surface.c
       src/vk_renderer.c
+      src/vulkan.c
     )
     target_link_libraries(flutterpi_module PUBLIC
       PkgConfig::VULKAN

CMakePresets.json

@@ -7,15 +7,58 @@
             "description": "Sets Ninja generator, build and install directory",
             "generator": "Ninja",
             "binaryDir": "${sourceDir}/out/build/${presetName}",
+            "hidden": true,
             "cacheVariables": {
                 "CMAKE_BUILD_TYPE": "Debug",
                 "CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}",
+                "TRY_ENABLE_OPENGL": false,
                 "ENABLE_OPENGL": true,
+                "TRY_ENABLE_VULKAN": false,
+                "ENABLE_VULKAN": true,
+                "BUILD_GSTREAMER_VIDEO_PLAYER_PLUGIN": true,
+                "TRY_BUILD_GSTREAMER_VIDEO_PLAYER_PLUGIN": false,
                 "BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN": true,
+                "TRY_BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN": false,
                 "BUILD_SENTRY_PLUGIN": true,
                 "ENABLE_TESTS": true
             }
         },
+        {
+            "name": "default-clang",
+            "displayName": "Default OpenGL host build (clang)",
+            "description": "Sets Ninja generator, build and install directory",
+            "generator": "Ninja",
+            "binaryDir": "${sourceDir}/out/build/${presetName}",
+            "inherits": "default",
+            "cacheVariables": {
+                "CMAKE_C_COMPILER": "clang",
+                "CMAKE_CXX_COMPILER": "clang++"
+            }
+        },
+        {
+            "name": "default-clang-20",
+            "displayName": "Default OpenGL host build (clang-20)",
+            "description": "Sets Ninja generator, build and install directory",
+            "generator": "Ninja",
+            "binaryDir": "${sourceDir}/out/build/${presetName}",
+            "inherits": "default",
+            "cacheVariables": {
+                "CMAKE_C_COMPILER": "clang-20",
+                "CMAKE_CXX_COMPILER": "clang++-20"
+            }
+        },
+        {
+            "name": "default-gcc",
+            "displayName": "Default OpenGL host build (gcc)",
+            "description": "Sets Ninja generator, build and install directory",
+            "generator": "Ninja",
+            "binaryDir": "${sourceDir}/out/build/${presetName}",
+            "inherits": "default",
+            "cacheVariables": {
+                "CMAKE_C_COMPILER": "gcc",
+                "CMAKE_CXX_COMPILER": "g++"
+            }
+        },
         {
             "name": "cross-aarch64-default",
             "displayName": "OpenGL AArch64 cross-build",
@@ -41,4 +84,4 @@
             }
         }
     ]
-}
+}

src/compositor_ng.c

@@ -20,6 +20,7 @@
 #include <semaphore.h>
 
 #include <flutter_embedder.h>
+#include <mesa3d/dynarray.h>
 #include <systemd/sd-event.h>
 
 #include "cursor.h"
@@ -33,7 +34,6 @@
 #include "surface.h"
 #include "tracer.h"
 #include "util/collection.h"
-#include "util/dynarray.h"
 #include "util/logging.h"
 #include "util/refcounting.h"
 #include "window.h"
@@ -231,7 +231,7 @@ static void fill_platform_view_layer_props(
     size_t n_mutations,
     const struct mat3f *display_to_view_transform,
     const struct mat3f *view_to_display_transform,
-    double device_pixel_ratio
+    float device_pixel_ratio
 ) {
     (void) view_to_display_transform;
 
@@ -262,8 +262,8 @@ static void fill_platform_view_layer_props(
 	 * ```
 	 */
 
-    rect.size.x /= device_pixel_ratio;
-    rect.size.y /= device_pixel_ratio;
+    rect.size.x /= (double) device_pixel_ratio;
+    rect.size.y /= (double) device_pixel_ratio;
 
     // okay, now we have the params.finalBoundingRect().x() in aa_back_transformed.x and
     // params.finalBoundingRect().y() in aa_back_transformed.y.
@@ -348,8 +348,9 @@ static int compositor_push_fl_layers(struct compositor *compositor, size_t n_fl_
             /// TODO: Implement
             layer->surface = compositor_get_view_by_id_locked(compositor, fl_layer->platform_view->identifier);
             if (layer->surface == NULL) {
-                layer->surface =
-                    CAST_SURFACE(dummy_render_surface_new(compositor->tracer, VEC2I(fl_layer->size.width, fl_layer->size.height)));
+                layer->surface = CAST_SURFACE(
+                    dummy_render_surface_new(compositor->tracer, VEC2I((int) fl_layer->size.width, (int) fl_layer->size.height))
+                );
             }
 #else
             // in release mode, we just assume the id is valid.
@@ -384,10 +385,6 @@ static int compositor_push_fl_layers(struct compositor *compositor, size_t n_fl_
 
     fl_layer_composition_unref(composition);
 
-    return 0;
-
-    //fail_free_composition:
-    //fl_layer_composition_unref(composition);
     return ok;
 }
 
@@ -556,14 +553,14 @@ void compositor_set_cursor(
 
         struct view_geometry viewgeo = window_get_view_geometry(compositor->main_window);
 
-        if (compositor->cursor_pos.x < 0.0f) {
-            compositor->cursor_pos.x = 0.0f;
+        if (compositor->cursor_pos.x < 0.0) {
+            compositor->cursor_pos.x = 0.0;
         } else if (compositor->cursor_pos.x > viewgeo.view_size.x) {
             compositor->cursor_pos.x = viewgeo.view_size.x;
         }
 
-        if (compositor->cursor_pos.y < 0.0f) {
-            compositor->cursor_pos.y = 0.0f;
+        if (compositor->cursor_pos.y < 0.0) {
+            compositor->cursor_pos.y = 0.0;
         } else if (compositor->cursor_pos.y > viewgeo.view_size.y) {
             compositor->cursor_pos.y = viewgeo.view_size.y;
         }

src/cursor.c

@@ -7,12 +7,12 @@
 #include "util/collection.h"
 #include "util/geometry.h"
 
-#define PIXEL_RATIO_LDPI 1.25
-#define PIXEL_RATIO_MDPI 1.6666
-#define PIXEL_RATIO_HDPI 2.5
-#define PIXEL_RATIO_XHDPI 3.3333
-#define PIXEL_RATIO_XXHDPI 5
-#define PIXEL_RATIO_XXXHDPI 6.6666
+#define PIXEL_RATIO_LDPI 1.25f
+#define PIXEL_RATIO_MDPI 1.6666f
+#define PIXEL_RATIO_HDPI 2.5f
+#define PIXEL_RATIO_XHDPI 3.3333f
+#define PIXEL_RATIO_XXHDPI 5.0f
+#define PIXEL_RATIO_XXXHDPI 6.6666f
 
 struct pointer_icon {
     enum pointer_kind kind;
@@ -1450,7 +1450,7 @@ static void run_length_decode(void *image_buf, const void *rle_data, size_t size
     }
 }
 
-const struct pointer_icon *pointer_icon_for_details(enum pointer_kind kind, double pixel_ratio) {
+const struct pointer_icon *pointer_icon_for_details(enum pointer_kind kind, float pixel_ratio) {
     const struct pointer_icon *best;
 
     best = NULL;
@@ -1461,7 +1461,7 @@ const struct pointer_icon *pointer_icon_for_details(enum pointer_kind kind, doub
             if (best == NULL) {
                 best = icon;
                 continue;
-            } else if (fabs(pixel_ratio - icon->pixel_ratio) < fabs(pixel_ratio - best->pixel_ratio)) {
+            } else if (fabsf(pixel_ratio - icon->pixel_ratio) < fabsf(pixel_ratio - best->pixel_ratio)) {
                 best = icon;
                 continue;
             }

src/cursor.h

@@ -56,7 +56,7 @@ enum pointer_kind {
 
 struct pointer_icon;
 
-const struct pointer_icon *pointer_icon_for_details(enum pointer_kind kind, double pixel_ratio);
+const struct pointer_icon *pointer_icon_for_details(enum pointer_kind kind, float pixel_ratio);
 
 enum pointer_kind pointer_icon_get_kind(const struct pointer_icon *icon);
 

src/dmabuf_surface.c

@@ -68,7 +68,7 @@ void refcounted_dmabuf_destroy(struct refcounted_dmabuf *dmabuf) {
     free(dmabuf);
 }
 
-DEFINE_STATIC_REF_OPS(refcounted_dmabuf, n_refs);
+DEFINE_STATIC_REF_OPS(refcounted_dmabuf, n_refs)
 
 struct dmabuf_surface {
     struct surface surface;
@@ -298,10 +298,10 @@ static int dmabuf_surface_present_kms(struct surface *_s, const struct fl_layer_
             .src_w = DOUBLE_TO_FP1616_ROUNDED(s->next_buf->buf.width),
             .src_h = DOUBLE_TO_FP1616_ROUNDED(s->next_buf->buf.height),
 
-            .dst_x = props->aa_rect.offset.x,
-            .dst_y = props->aa_rect.offset.y,
-            .dst_w = props->aa_rect.size.x,
-            .dst_h = props->aa_rect.size.y,
+            .dst_x = (int) round(props->aa_rect.offset.x),
+            .dst_y = (int) round(props->aa_rect.offset.y),
+            .dst_w = (int) round(props->aa_rect.size.x),
+            .dst_h = (int) round(props->aa_rect.size.y),
 
             .has_rotation = false,
             .rotation = PLANE_TRANSFORM_ROTATE_0,

src/egl.h

@@ -475,7 +475,8 @@ static inline const char *egl_strerror(EGLenum result) {
     }
 }
 
-    #define LOG_EGL_ERROR(result, fmt, ...) LOG_ERROR(fmt ": %s\n", __VA_ARGS__ egl_strerror(result))
+    #define LOG_EGL_ERROR_FMT(result, fmt, ...) LOG_ERROR(fmt ": %s\n", __VA_ARGS__ egl_strerror(result))
+    #define LOG_EGL_ERROR(result, fmt) LOG_ERROR(fmt ": %s\n", egl_strerror(result))
 #endif
 
 #endif  // _FLUTTERPI_SRC_EGL_H