Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on dependency logging not up to date #449

Open
meersschautarnaud opened this issue Aug 3, 2022 · 5 comments
Open

Documentation on dependency logging not up to date #449

meersschautarnaud opened this issue Aug 3, 2022 · 5 comments
Assignees
Labels
dependencies All issues related to dependencies documentation All issues related to documentation enhancement New feature or request question Further information is requested
Milestone

Comments

@meersschautarnaud
Copy link
Contributor

Describe the bug
Looking at the documentation on how to log a service bus dependency it shows a method that is obsolete. Next to that in the new methods, you need to provide a dependencyId which is a bit confusing since correlation is normally handled by Arcus itself, but this is probably another discussion.

Additional context

  • Version: 2.5
@stijnmoreels
Copy link
Member

stijnmoreels commented Aug 3, 2022

Hi Arnaud, thx for the issue.

I can see your confusion. This, however, is not a mistake or bug but was done on purpose. Tracking dependencies happens in two parts:

  • Adding correlation information to the sent message (ex. in Azure Service Bus, the ApplicationProperties)
  • Logging dependency with correlation information (ex. Azure Service Bus dependency with dependency ID)

In order for Arcus to know how the called dependency is calling itself, a dependency ID has to be passed while logging the dependency.

We are working on a set of extensions that extends the ServiceBusSender which will do these two steps for you: https://github.com/arcus-azure/arcus.messaging/blob/master/docs/preview/02-Features/04-service-bus-extensions.md but this isn't yet released, though, the published releases already has everything to do this yourself.
If you're interested in this extension, we can already provide you with a preview release to experiment with this.

Service-to-service correlation is a very complex topic to get right, so we are working also on several user guides to help consumers in this process. 👍

@stijnmoreels stijnmoreels added the question Further information is requested label Aug 3, 2022
@stijnmoreels
Copy link
Member

stijnmoreels commented Aug 3, 2022

We could, however, add the dependencyId to every method in the docs so people know that this is the recommended approach. 👍
Something you would want to pick up?

@meersschautarnaud
Copy link
Contributor Author

@stijnmoreels thank you for the explanation, I would like to pick this up and update the docs 😃

@stijnmoreels
Copy link
Member

@stijnmoreels thank you for the explanation, I would like to pick this up and update the docs 😃

Great! Thx for the help!
Let us know if you have any questions.

@stijnmoreels stijnmoreels added documentation All issues related to documentation enhancement New feature or request dependencies All issues related to dependencies labels Aug 3, 2022
@stijnmoreels stijnmoreels added this to the v2.6.0 milestone Aug 3, 2022
@stijnmoreels stijnmoreels modified the milestones: v2.6.0, v2.7.0 Oct 18, 2022
@stijnmoreels
Copy link
Member

@meersschautarnaud , letting you know that with the new Arcus telemetry in Web API/Messaging, we can now automatically track Microsoft dependencies (HTTP, SQL, all Azure dependencies...) without any additional Arcus dependency tracking.

@stijnmoreels stijnmoreels modified the milestones: v2.7.0, v2.8.0 Jan 9, 2023
@stijnmoreels stijnmoreels modified the milestones: v2.8.0, v2.9.0 Jan 20, 2023
@stijnmoreels stijnmoreels modified the milestones: v2.9.0, v3.1.0 Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies All issues related to dependencies documentation All issues related to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants