Enable Ruff collection-literal-concatenation rule (#4818)

Author: codefiles

archinstall/default_profiles/desktops/labwc.py

@@ -21,7 +21,8 @@ def packages(self) -> list[str]:
 		return [
 			'alacritty',
 			'labwc',
-		] + seat_access_packages(self.custom_settings.get(CustomSetting.SeatAccess))
+			*seat_access_packages(self.custom_settings.get(CustomSetting.SeatAccess)),
+		]
 
 	@property
 	@override

archinstall/default_profiles/desktops/niri.py

@@ -29,7 +29,8 @@ def packages(self) -> list[str]:
 			'swayidle',
 			'swaylock',
 			'xdg-desktop-portal-gnome',
-		] + seat_access_packages(self.custom_settings.get(CustomSetting.SeatAccess))
+			*seat_access_packages(self.custom_settings.get(CustomSetting.SeatAccess)),
+		]
 
 	@property
 	@override

archinstall/default_profiles/desktops/sway.py

@@ -31,7 +31,8 @@ def packages(self) -> list[str]:
 			'pavucontrol',
 			'foot',
 			'xorg-xwayland',
-		] + seat_access_packages(self.custom_settings.get(CustomSetting.SeatAccess))
+			*seat_access_packages(self.custom_settings.get(CustomSetting.SeatAccess)),
+		]
 
 	@property
 	@override

archinstall/lib/disk/partitioning_menu.py

@@ -148,7 +148,7 @@ def as_segments(self, device_partitions: list[PartitionModification]) -> list[Di
 		if not partitions:
 			free_space = FreeSpace(self._buffer, end)
 			if free_space.length > self._buffer:
-				return segments + [DiskSegment(free_space)]
+				return [*segments, DiskSegment(free_space)]
 			return segments
 
 		first_part_index, first_partition = next(

archinstall/lib/disk/utils.py

@@ -188,7 +188,7 @@ def umount(mountpoint: Path | str, recursive: bool = False) -> None:
 
 	for path in lsblk_info.mountpoints:
 		debug(f'Unmounting mountpoint: {path}')
-		SysCommand(cmd + [str(path)])
+		SysCommand([*cmd, str(path)])
 
 
 def swapon(path: Path) -> None:

archinstall/lib/installer.py

@@ -379,7 +379,7 @@ def _mount_partition(self, part_mod: PartitionModification) -> None:
 			options = part_mod.mount_options
 
 			if part_mod.is_efi():
-				options = list(dict.fromkeys(options + ['fmask=0177', 'dmask=0077']))
+				options = list(dict.fromkeys([*options, 'fmask=0177', 'dmask=0077']))
 
 			mount(part_mod.dev_path, target, options=options)
 		elif part_mod.fs_type == FilesystemType.BTRFS:
@@ -444,7 +444,7 @@ def _mount_btrfs_subvol(
 		subvols_with_mountpoints = [sv for sv in subvolumes if sv.mountpoint is not None]
 		for subvol in sorted(subvols_with_mountpoints, key=lambda x: x.relative_mountpoint):
 			mountpoint = self.target / subvol.relative_mountpoint
-			options = mount_options + [f'subvol={subvol.name}']
+			options = [*mount_options, f'subvol={subvol.name}']
 			mount(dev_path, mountpoint, options=options)
 
 	def generate_key_files(self) -> None:

archinstall/lib/menu/list_manager.py

@@ -97,7 +97,7 @@ async def _run(self) -> list[ValueT] | None:
 		return self._data
 
 	async def _run_actions_on_entry(self, entry: ValueT) -> None:
-		options = self.filter_options(entry, self._sub_menu_actions) + [self._cancel_action]
+		options = [*self.filter_options(entry, self._sub_menu_actions), self._cancel_action]
 
 		items = [MenuItem(o, value=o) for o in options]
 		group = MenuItemGroup(items, sort_items=False)

pyproject.toml

@@ -229,7 +229,6 @@ ignore = [
     "PLC1901",  # compare-to-empty-string
     "PLW1514",  # unspecified-encoding
     "PLW1641",  # eq-without-hash
-    "RUF005",   # collection-literal-concatenation
     "RUF039",   # unraw-re-pattern
     "W191",     # tab-indentation
 ]