add UT

Author: jwierzbo

pkg/deployment/reconcile/plan_builder_test.go

@@ -23,6 +23,7 @@ package reconcile
 import (
 	"context"
 	"fmt"
+	"github.com/arangodb/kube-arangodb/pkg/deployment/resources"
 	"io/ioutil"
 	"testing"
 	"time"
@@ -49,7 +50,6 @@ import (
 	"github.com/arangodb/kube-arangodb/pkg/deployment/patch"
 	pod2 "github.com/arangodb/kube-arangodb/pkg/deployment/pod"
 	"github.com/arangodb/kube-arangodb/pkg/deployment/reconciler"
-	"github.com/arangodb/kube-arangodb/pkg/deployment/resources"
 	"github.com/arangodb/kube-arangodb/pkg/generated/clientset/versioned"
 	"github.com/arangodb/kube-arangodb/pkg/logging"
 	"github.com/arangodb/kube-arangodb/pkg/util"
@@ -81,13 +81,13 @@ type testContext struct {
 	PVC              *core.PersistentVolumeClaim
 	PVCErr           error
 	RecordedEvent    *k8sutil.Event
+	ArangoTask       *api.ArangoTask
 
 	Inspector inspectorInterface.Inspector
 }
 
 func (c *testContext) GetNextTask(ctx context.Context) (*api.ArangoTask, error) {
-	//TODO implement me
-	panic("implement me")
+	return c.ArangoTask, nil
 }
 
 func (c *testContext) GetAgencyHealth() (agencyCache.Health, bool) {
@@ -696,6 +696,7 @@ type testCase struct {
 	ExpectedError    error
 	ExpectedPlan     api.Plan
 	ExpectedHighPlan api.Plan
+	ExpectedTaskPlan api.Plan
 	ExpectedLog      string
 	ExpectedEvent    *k8sutil.Event
 
@@ -761,6 +762,17 @@ func TestCreatePlan(t *testing.T) {
 	addAgentsToStatus(t, &deploymentTemplate.Status, 3)
 	deploymentTemplate.Spec.SetDefaults("createPlanTest")
 
+	arangoTaskTemplate := &api.ArangoTask{
+		ObjectMeta: meta.ObjectMeta{
+			Name:      "test_task",
+			Namespace: tests.FakeNamespace,
+		},
+		Spec: api.ArangoTaskSpec{
+			Type:           api.ArangoTaskPingType,
+			DeploymentName: "test_depl",
+		},
+	}
+
 	testCases := []testCase{
 		{
 			Name: "Can not create plan for single deployment",
@@ -1173,6 +1185,18 @@ func TestCreatePlan(t *testing.T) {
 			},
 			ExpectedLog: "Creating scale-down plan",
 		},
+		{
+			Name: "ArangoTask - ping type",
+			context: &testContext{
+				ArangoDeployment: deploymentTemplate.DeepCopy(),
+				ArangoTask:       arangoTaskTemplate,
+			},
+
+			ExpectedTaskPlan: []api.Action{
+				actions.NewClusterAction(api.ActionTypePing, "Pinging database server"),
+			},
+			ExpectedLog: "Pinging database server",
+		},
 	}
 
 	for _, testCase := range testCases {
@@ -1242,6 +1266,17 @@ func TestCreatePlan(t *testing.T) {
 					assert.Equal(t, v.Reason, status.Plan[i].Reason)
 				}
 			}
+
+			if len(testCase.ExpectedTaskPlan) > 0 {
+				require.Len(t, status.TaskPlan, len(testCase.ExpectedTaskPlan))
+				for i, v := range testCase.ExpectedTaskPlan {
+					assert.Equal(t, v.Type, status.TaskPlan[i].Type)
+					assert.Equal(t, v.Group, status.TaskPlan[i].Group)
+					if v.Reason != "*" {
+						assert.Equal(t, v.Reason, status.TaskPlan[i].Reason)
+					}
+				}
+			}
 		})
 	}
 }