OAS-10576 fix vulncheck errors (#658)

* Updated go to 1.22.11

* Change log + jwt v5 update

* Added LSP Compatible Deprecated tags

Author: enikon

.circleci/config.yml

@@ -4,7 +4,7 @@ orbs:
 executors:
   golang-executor:
     docker:
-      - image: gcr.io/gcr-for-testing/golang:1.22.8
+      - image: gcr.io/gcr-for-testing/golang:1.22.11
   machine-executor:
     machine:
       image: ubuntu-2204:current

CHANGELOG.md

@@ -2,11 +2,15 @@
 
 ## [master](https://github.com/arangodb/go-driver/tree/master) (N/A)
 
-## [1.6.5(https://github.com/arangodb/go-driver/tree/v1.6.5) (2024-11-15)
+## [1.6.6](https://github.com/arangodb/go-driver/tree/v1.6.6) (2025-02-21)
+- Switch to Go 1.22.11
+- Switch to jwt-go v5
+
+## [1.6.5](https://github.com/arangodb/go-driver/tree/v1.6.5) (2024-11-15)
 - Expose `NewType` method
 - Switch to Go 1.22.8
 
-## [1.6.4(https://github.com/arangodb/go-driver/tree/v1.6.4) (2024-09-27)
+## [1.6.4](https://github.com/arangodb/go-driver/tree/v1.6.4) (2024-09-27)
 - Switch to Go 1.22.5
 - Switch to Go 1.22.6
 

Makefile

@@ -4,7 +4,7 @@ SCRIPTDIR := $(shell pwd)
 CURR=$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))
 ROOTDIR:=$(CURR)
 
-GOVERSION ?= 1.22.8
+GOVERSION ?= 1.22.11
 GOIMAGE ?= golang:$(GOVERSION)
 GOV2IMAGE ?= $(GOIMAGE)
 ALPINE_IMAGE ?= alpine:3.17

agency/agency.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2020-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2020-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -45,41 +45,49 @@ type Agency interface {
 	***/
 
 	// Deprecated: TTL param is removed since 3.12, use WriteTransaction instead
+	//
 	// WriteKey writes the given value with the given key with a given TTL (unless TTL is zero).
 	// If you pass a condition (only 1 allowed), this condition has to be true,
 	// otherwise the write will fail with a ConditionFailed error.
 	WriteKey(ctx context.Context, key []string, value interface{}, ttl time.Duration, condition ...WriteCondition) error
 
 	// Deprecated: use 'WriteTransaction' instead
+	//
 	// WriteKeyIfEmpty writes the given value with the given key only if the key was empty before.
 	WriteKeyIfEmpty(ctx context.Context, key []string, value interface{}, ttl time.Duration) error
 
 	// Deprecated: use 'WriteTransaction' instead
+	//
 	// WriteKeyIfEqualTo writes the given new value with the given key only if the existing value for that key equals
 	// to the given old value.
 	WriteKeyIfEqualTo(ctx context.Context, key []string, newValue, oldValue interface{}, ttl time.Duration) error
 
 	// Deprecated: use 'WriteTransaction' instead
+	//
 	// RemoveKey removes the given key.
 	// If you pass a condition (only 1 allowed), this condition has to be true,
 	// otherwise the remove will fail with a ConditionFailed error.
 	RemoveKey(ctx context.Context, key []string, condition ...WriteCondition) error
 
 	// Deprecated: use 'WriteTransaction' instead
+	//
 	// RemoveKeyIfEqualTo removes the given key only if the existing value for that key equals
 	// to the given old value.
 	RemoveKeyIfEqualTo(ctx context.Context, key []string, oldValue interface{}) error
 
 	// Deprecated: use 'WriteTransaction' instead
+	//
 	// Register a URL to receive notification callbacks when the value of the given key changes
 	RegisterChangeCallback(ctx context.Context, key []string, cbURL string) error
 
 	// Deprecated: use 'WriteTransaction' instead
+	//
 	// Register a URL to receive notification callbacks when the value of the given key changes
 	UnregisterChangeCallback(ctx context.Context, key []string, cbURL string) error
 }
 
 // Deprecated: use 'agency.KeyConditioner' instead
+//
 // WriteCondition is a precondition before a write is accepted.
 type WriteCondition struct {
 	conditions map[string]writeCondition
@@ -99,6 +107,7 @@ func (c WriteCondition) add(key []string, updater func(wc *writeCondition)) Writ
 }
 
 // Deprecated: use 'agency.KeyConditioner' instead
+//
 // IfEmpty adds an "is empty" check on the given key to the given condition
 // and returns the updated condition.
 func (c WriteCondition) IfEmpty(key []string) WriteCondition {
@@ -108,6 +117,7 @@ func (c WriteCondition) IfEmpty(key []string) WriteCondition {
 }
 
 // Deprecated: use 'agency.KeyConditioner' instead
+//
 // IfIsArray adds an "is-array" check on the given key to the given condition
 // and returns the updated condition.
 func (c WriteCondition) IfIsArray(key []string) WriteCondition {
@@ -117,6 +127,7 @@ func (c WriteCondition) IfIsArray(key []string) WriteCondition {
 }
 
 // Deprecated: use 'agency.KeyConditioner' instead
+//
 // IfEqualTo adds an "value equals oldValue" check to given old value on the
 // given key to the given condition and returns the updated condition.
 func (c WriteCondition) IfEqualTo(key []string, oldValue interface{}) WriteCondition {

agency/agency_impl.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2020-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2020-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -143,6 +143,7 @@ type writeResult struct {
 }
 
 // Deprecated: use 'WriteTransaction' instead
+//
 // WriteKey writes the given value with the given key with a given TTL (unless TTL is zero).
 // If you pass a condition (only 1 allowed), this condition has to be true,
 // otherwise the write will fail with a ConditionFailed error.
@@ -171,6 +172,7 @@ func (c *agency) WriteKey(ctx context.Context, key []string, value interface{},
 }
 
 // Deprecated: use 'WriteTransaction' instead
+//
 // WriteKeyIfEmpty writes the given value with the given key only if the key was empty before.
 func (c *agency) WriteKeyIfEmpty(ctx context.Context, key []string, value interface{}, ttl time.Duration) error {
 	transaction := NewTransaction("", TransactionOptions{})
@@ -185,6 +187,7 @@ func (c *agency) WriteKeyIfEmpty(ctx context.Context, key []string, value interf
 }
 
 // Deprecated: use 'WriteTransaction' instead
+//
 // WriteKeyIfEqualTo writes the given new value with the given key only if the existing value for that key equals
 // to the given old value.
 func (c *agency) WriteKeyIfEqualTo(ctx context.Context, key []string, newValue, oldValue interface{}, ttl time.Duration) error {
@@ -281,6 +284,7 @@ func (c *agency) WriteTransaction(ctx context.Context, transaction Transaction)
 }
 
 // Deprecated: use 'WriteTransaction' instead
+//
 // RemoveKey removes the given key.
 // If you pass a condition (only 1 allowed), this condition has to be true,
 // otherwise the remove will fail with a ConditionFailed error.
@@ -310,6 +314,7 @@ func (c *agency) RemoveKey(ctx context.Context, key []string, condition ...Write
 }
 
 // Deprecated: use 'WriteTransaction' instead
+//
 // RemoveKeyIfEqualTo removes the given key only if the existing value for that key equals
 // to the given old value.
 func (c *agency) RemoveKeyIfEqualTo(ctx context.Context, key []string, oldValue interface{}) error {
@@ -325,6 +330,7 @@ func (c *agency) RemoveKeyIfEqualTo(ctx context.Context, key []string, oldValue
 }
 
 // Deprecated: use 'WriteTransaction' instead
+//
 // Register a URL to receive notification callbacks when the value of the given key changes
 func (c *agency) RegisterChangeCallback(ctx context.Context, key []string, cbURL string) error {
 	transaction := NewTransaction("", TransactionOptions{})
@@ -338,6 +344,7 @@ func (c *agency) RegisterChangeCallback(ctx context.Context, key []string, cbURL
 }
 
 // Deprecated: use 'WriteTransaction' instead
+//
 // Register a URL to receive notification callbacks when the value of the given key changes
 func (c *agency) UnregisterChangeCallback(ctx context.Context, key []string, cbURL string) error {
 

agency/operation.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2020-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2020-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -38,6 +38,7 @@ type KeyChanger interface {
 	GetVal() interface{}
 
 	// Deprecated: removed since 3.12
+	//
 	// GetTTL returns how long (in seconds) a key will live in the agency
 	GetTTL() time.Duration
 }
@@ -113,6 +114,7 @@ func NewKeySetV2(key []string, value interface{}) KeyChanger {
 }
 
 // NewKeySet returns a new key operation which must be set in the agency
+//
 // Deprecated: TTL param is removed since 3.12, use NewKeySetV2 instead
 func NewKeySet(key []string, value interface{}, TTL time.Duration) KeyChanger {
 	return &keySet{
@@ -127,6 +129,7 @@ func NewKeySet(key []string, value interface{}, TTL time.Duration) KeyChanger {
 // NewKeyObserve returns a new key callback operation which must be written in the agency.
 // URL parameter describes where callback must be sent in case of changes on a key.
 // When 'observe' is false then we want to stop observing a key.
+//
 // Deprecated: observe param is removed since 3.12
 func NewKeyObserve(key []string, URL string, observe bool) KeyChanger {
 	return &keyObserve{

client.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -114,6 +114,7 @@ type ClientConfig struct {
 	Authentication Authentication
 
 	// Deprecated: using non-zero duration causes routine leak. Please create your own implementation using Client.SynchronizeEndpoints2
+	//
 	// SynchronizeEndpointsInterval is the interval between automatic synchronization of endpoints.
 	// If this value is 0, no automatic synchronization is performed.
 	// If this value is > 0, automatic synchronization is started on a go routine.

client_admin_backup.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -62,7 +62,7 @@ type BackupCreateOptions struct {
 
 	Timeout time.Duration `json:"timeout,omitempty"`
 
-	// @deprecated - since 3.10.10 it exists only for backwards compatibility
+	// Deprecated: - since 3.10.10 it exists only for backwards compatibility
 	AllowInconsistent bool `json:"allowInconsistent,omitempty"`
 }
 

client_impl.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -107,6 +107,7 @@ func (c *client) SynchronizeEndpoints2(ctx context.Context, dbname string) error
 }
 
 // Deprecated: should not be called in new code.
+//
 // autoSynchronizeEndpoints performs automatic endpoint synchronization.
 func (c *client) autoSynchronizeEndpoints(interval time.Duration) {
 	for {

client_server_admin.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -56,6 +56,7 @@ type ClientServerAdmin interface {
 	MetricsForSingleServer(ctx context.Context, serverID string) ([]byte, error)
 
 	// Deprecated: Use Metrics instead.
+	//
 	// Statistics queries statistics from a specific server
 	Statistics(ctx context.Context) (ServerStatistics, error)
 

collection_indexes.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017-2024 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -35,6 +35,7 @@ type CollectionIndexes interface {
 	Indexes(ctx context.Context) ([]Index, error)
 
 	// Deprecated: since 3.10 version. Use ArangoSearch view instead.
+	//
 	// EnsureFullTextIndex creates a fulltext index in the collection, if it does not already exist.
 	// Fields is a slice of attribute names. Currently, the slice is limited to exactly one attribute.
 	// The index is returned, together with a boolean indicating if the index was newly created (true) or pre-existing (false).
@@ -90,6 +91,7 @@ type CollectionIndexes interface {
 }
 
 // Deprecated: since 3.10 version. Use ArangoSearch view instead.
+//
 // EnsureFullTextIndexOptions contains specific options for creating a full text index.
 type EnsureFullTextIndexOptions struct {
 	// MinLength is the minimum character length of words to index. Will default to a server-defined

collection_indexes_impl.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017-2024 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -138,6 +138,7 @@ func (c *collection) Indexes(ctx context.Context) ([]Index, error) {
 }
 
 // Deprecated: since 3.10 version. Use ArangoSearch view instead.
+//
 // EnsureFullTextIndex creates a fulltext index in the collection, if it does not already exist.
 //
 // Fields is a slice of attribute names. Currently, the slice is limited to exactly one attribute.

database_arangosearch_analyzers.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+// Copyright 2018-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -50,6 +50,7 @@ type ArangoSearchAnalyzer interface {
 type DatabaseArangoSearchAnalyzers interface {
 
 	// Deprecated: Use EnsureCreatedAnalyzer instead
+	//
 	// Ensure ensures that the given analyzer exists. If it does not exist it is created.
 	// The function returns whether the analyzer already existed or an error.
 	EnsureAnalyzer(ctx context.Context, analyzer ArangoSearchAnalyzerDefinition) (bool, ArangoSearchAnalyzer, error)

database_arangosearch_analyzers_impl.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+// Copyright 2018-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -92,6 +92,7 @@ func (a *analyzer) Database() Database {
 }
 
 // Deprecated: Use EnsureCreatedAnalyzer instead
+//
 // Ensure ensures that the given analyzer exists. If it does not exist it is created.
 // The function returns whether the analyzer already existed or an error.
 func (d *database) EnsureAnalyzer(ctx context.Context, definition ArangoSearchAnalyzerDefinition) (bool, ArangoSearchAnalyzer, error) {

database_collections.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -177,6 +177,7 @@ type CollectionKeyOptions struct {
 	// If set to true, then it is allowed to supply own key values in the _key attribute of a document.
 	// If set to false, then the key generator will solely be responsible for generating keys and supplying own
 	// key values in the _key attribute of documents is considered an error.
+	//
 	// Deprecated: Use AllowUserKeysPtr instead
 	AllowUserKeys bool `json:"-"`
 	// If set to true, then it is allowed to supply own key values in the _key attribute of a document.

database_graphs.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2017 ArangoDB GmbH, Cologne, Germany
+// Copyright 2017-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -42,6 +42,7 @@ type DatabaseGraphs interface {
 
 	// CreateGraph creates a new graph with given name and options, and opens a connection to it.
 	// If a graph with given name already exists within the database, a DuplicateError is returned.
+	//
 	// Deprecated: since ArangoDB 3.9 - please use CreateGraphV2 instead
 	CreateGraph(ctx context.Context, name string, options *CreateGraphOptions) (Graph, error)