Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Change long_id format #1416

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Jan 15, 2025

Close #1415

#todo : doc + CI (. in the names to add)

@AliceJoubert AliceJoubert self-assigned this Jan 15, 2025
@AliceJoubert AliceJoubert marked this pull request as draft January 15, 2025 14:21
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A non trivial example of where such a change would have consequences not captured by our tests (I think):

image_ids = [
re.search(r"(sub-[a-zA-Z0-9]+)_(long-[a-zA-Z0-9]+)", file).group()
for file in t1_freesurfer_files
]

@AliceJoubert
Copy link
Contributor Author

A non trivial example of where such a change would have consequences not captured by our tests (I think):

image_ids = [
re.search(r"(sub-[a-zA-Z0-9]+)_(long-[a-zA-Z0-9]+)", file).group()
for file in t1_freesurfer_files
]

Thanks for spotting that ! I can modify the regex depending on the separator we want to use. I made the modifications in the PR with "." but that might not be the best choice since it is widely used. We can also go with "+". WDYT ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpractical longitudinal filenaming
2 participants